Skip to content

Add dictionaries to avoid header parsing#50705

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
makortel:missiongDictionariesRNTuple
Apr 22, 2026
Merged

Add dictionaries to avoid header parsing#50705
cmsbuild merged 2 commits into
cms-sw:masterfrom
makortel:missiongDictionariesRNTuple

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Apr 13, 2026

PR description:

This PR adds dictionaries for types that were found to cause header parsing in ROOT master in #50580 (comment) (for TTree IO) and #49949 (comment) (for RNTuple IO)

Resolves cms-sw/framework-team#2153

PR validation:

With these changes the gInterpreter->Print("autoparsed") (via #50632) no longer listed types causing header parsing that we could easily do something about.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 13, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50705/48974

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/BTauReco (reconstruction)
  • DataFormats/CSCRecHit (reconstruction)
  • DataFormats/CTPPSReco (reconstruction)
  • DataFormats/Candidate (reconstruction)
  • DataFormats/DTRecHit (reconstruction)
  • DataFormats/EcalRecHit (reconstruction)
  • DataFormats/EgammaCandidates (reconstruction)
  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/GEMRecHit (reconstruction)
  • DataFormats/GsfTrackReco (reconstruction)
  • DataFormats/HcalRecHit (reconstruction)
  • DataFormats/HepMCCandidate (generators)
  • DataFormats/JetReco (reconstruction)
  • DataFormats/PatCandidates (reconstruction, xpog)
  • DataFormats/TauReco (reconstruction)
  • DataFormats/VertexReco (reconstruction)

@Moanwar, @battibass, @cmsbuild, @ftorrresd, @jfernan2, @lviliani, @mandrenguyen, @mkirsano, @sensrcn, @srimanob, @theofil can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @HuguesBrun, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @abdoulline, @afiqaize, @ahinzmann, @andrzejnovak, @argiro, @azotz, @battibass, @bsunanda, @castaned, @cericeci, @elusian, @fabferro, @fsimone91, @gkasieczka, @gouskos, @gpetruc, @grzanka, @hatakeyamak, @jainshilpi, @jdamgov, @jdolen, @jhgoh, @jshlee, @lgray, @llunerti, @mariadalfonso, @mbluj, @missirol, @mmasciov, @mmusich, @mtosi, @nhanvtran, @pavlo-kashko, @philippgadow, @ptcox, @ram1123, @rappoccio, @rchatter, @rovere, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @thomreis, @trocino, @varuns23, @wang0jin, @watson-ij this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-484a3a/52635/summary.html
COMMIT: b64dae9
CMSSW: CMSSW_17_0_X_2026-04-13-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50705/52635/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Copy Markdown
Contributor

+1

@battibass
Copy link
Copy Markdown

+1

@makortel
Copy link
Copy Markdown
Contributor Author

Sorry, one more came up. This is the last update.

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50705/49013

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #50705 was updated. @Moanwar, @cmsbuild, @jfernan2, @lviliani, @mandrenguyen, @mkirsano, @sensrcn, @srimanob, @theofil can you please check and sign again.

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-484a3a/52686/summary.html
COMMIT: b3d77dc
CMSSW: CMSSW_17_0_X_2026-04-15-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50705/52686/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4420234
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4420150
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 235 log files, 207 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Copy Markdown
Contributor

+1

@makortel
Copy link
Copy Markdown
Contributor Author

@cms-sw/generators-l2 Could you review and sign, please?

@lviliani
Copy link
Copy Markdown
Contributor

+generators

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 013a403 into cms-sw:master Apr 22, 2026
10 checks passed
@makortel makortel deleted the missiongDictionariesRNTuple branch April 22, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing dictionaries found in TTree and RNTuple (Mini)AOD copy jobs

6 participants