Skip to content

Moved FWCore/TestProcessor to catch2#50610

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:catch2FWCoreTestProcessor
Apr 2, 2026
Merged

Moved FWCore/TestProcessor to catch2#50610
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:catch2FWCoreTestProcessor

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Mar 31, 2026

PR description:

Part of a campaign to reduce FWCore dependencies.

PR validation:

Code compiles, unit tests pass.

resolves cms-sw/framework-team#2123

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 31, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/TestProcessor (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a33e5/52369/summary.html
COMMIT: b3c2f27
CMSSW: CMSSW_16_1_X_2026-03-31-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50610/52369/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a33e5/52369/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a33e5/52369/git-merge-result

Comparison Summary

Summary:

  • You potentially added 67 lines to the logs
  • Reco comparison results: 12398 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4087656
  • DQMHistoTests: Total failures: 3817
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 4083807
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.03100000000000001 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 2024.0040001 ): 0.070 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0050001 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0060001 ): -0.023 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0070001 ): -0.004 KiB JetMET/SUSYDQM
  • Checked 223 log files, 194 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 2 / 50 workflows

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Apr 1, 2026

@cmsbuild, please test

To double-check the comparisons without the other PRs

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a33e5/52406/summary.html
COMMIT: b3c2f27
CMSSW: CMSSW_16_1_X_2026-04-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50610/52406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180749
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4180720
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

makortel commented Apr 1, 2026

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 1, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 033f656 into cms-sw:master Apr 2, 2026
10 checks passed
@Dr15Jones Dr15Jones deleted the catch2FWCoreTestProcessor branch April 7, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update TestProcessor

4 participants