[EVO] Moved data products in reco:: namespace to reco::io_v1 by Dr15Jones · Pull Request #49881 · cms-sw/cmssw

Dr15Jones · 2026-01-20T21:41:22Z

PR description:

classes in reco:: namespace which are stored in common data formats were moved to reco::io_v1 namespace
Forward references to those classes were handled via includes of a FWD file.
class versions were reset to 3

PR validation:

Code compiles.

resolves cms-sw/framework-team#1810

cmsbuild · 2026-01-20T21:41:58Z

cms-bot internal usage

cmsbuild · 2026-01-20T21:44:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49881/47590

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49881/47590/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49881/47590/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-20T22:00:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49881/47591

cmsbuild · 2026-01-20T22:01:18Z

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

Alignment/CommonAlignmentAlgorithm (alca)
Alignment/ReferenceTrajectories (alca)
AnalysisDataFormats/SUSYBSMObjects (analysis)
AnalysisDataFormats/TopObjects (analysis)
AnalysisDataFormats/TrackInfo (analysis)
CommonTools/CandAlgos (reconstruction)
CommonTools/CandUtils (reconstruction)
DQM/Physics (dqm)
DQM/TrackingMonitor (dqm)
DQM/TrackingMonitorSource (dqm)
DataFormats/BTauReco (reconstruction)
DataFormats/BeamSpot (reconstruction)
DataFormats/CaloRecHit (reconstruction)
DataFormats/CaloTowers (reconstruction)
DataFormats/Candidate (reconstruction)
DataFormats/CastorReco (reconstruction)
DataFormats/EgammaCandidates (reconstruction)
DataFormats/EgammaReco (reconstruction)
DataFormats/GsfTrackReco (reconstruction)
DataFormats/HGCalReco (reconstruction)
DataFormats/HLTReco (hlt)
DataFormats/HcalIsolatedTrack (reconstruction)
DataFormats/HepMCCandidate (generators)
DataFormats/JetMatching (simulation)
DataFormats/JetReco (reconstruction)
DataFormats/L1TCalorimeterPhase2 (l1)
DataFormats/L1TCorrelator (l1)
DataFormats/L1THGCal (l1)
DataFormats/L1TMuonPhase2 (l1)
DataFormats/L1TParticleFlow (l1)
DataFormats/L1Trigger (l1)
DataFormats/METReco (reconstruction)
DataFormats/MuonReco (reconstruction)
DataFormats/ParticleFlowCandidate (reconstruction)
DataFormats/ParticleFlowReco (reconstruction)
DataFormats/PatCandidates (reconstruction, xpog)
DataFormats/ProtonReco (reconstruction)
DataFormats/RecoCandidate (reconstruction)
DataFormats/TauReco (reconstruction)
DataFormats/TrackReco (reconstruction)
DataFormats/V0Candidate (reconstruction)
DataFormats/VertexReco (reconstruction)
Fireworks/Calo (visualization)
Fireworks/Core (visualization)
Fireworks/Electrons (visualization)
Fireworks/Muons (visualization)
Fireworks/ParticleFlow (visualization)
HLTrigger/btau (hlt)
HeavyFlavorAnalysis/RecoDecay (analysis)
HeavyFlavorAnalysis/SpecificDecay (analysis)
PhysicsTools/Heppy (analysis)
PhysicsTools/PatAlgos (reconstruction, xpog)
PhysicsTools/RecoUtils (analysis)
PhysicsTools/SelectorUtils (reconstruction)
RecoEgamma/EgammaElectronAlgos (reconstruction)
RecoEgamma/EgammaElectronProducers (reconstruction)
RecoEgamma/EgammaTools (reconstruction)
RecoEgamma/ElectronIdentification (reconstruction)
RecoHGCal/TICL (reconstruction)
RecoHI/HiTracking (reconstruction)
RecoJets/JetProducers (reconstruction)
RecoMuon/MuonIdentification (reconstruction)
RecoTauTag/RecoTau (reconstruction)
RecoTracker/PixelTrackFitting (reconstruction)
RecoVertex/BeamSpotProducer (alca, reconstruction)
RecoVertex/PrimaryVertexProducer (reconstruction)
SimDataFormats/Associations (simulation)
SimDataFormats/CaloAnalysis (simulation)
SimDataFormats/HiGenData (simulation)
SimDataFormats/TrackingAnalysis (simulation)
SimGeneral/DataMixingModule (simulation)
SimGeneral/PreMixingModule (simulation)
TrackingTools/GeomPropagators (reconstruction)
TrackingTools/GsfTracking (reconstruction)
Validation/RecoEgamma (dqm)
Validation/RecoTrack (dqm)
Validation/RecoVertex (dqm)

@Alejandro1400, @BenjaminRS, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @alja, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @nothingface0, @perrotta, @quinnanm, @rseidita, @sensrcn, @srimanob, @theofil, @tvami can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @afiqaize, @ahinzmann, @alja, @amagitte, @amarini, @andrzejnovak, @apsallid, @argiro, @arossi83, @azotz, @battibass, @bellan, @bsunanda, @castaned, @cericeci, @clelange, @denizsun, @dgulhan, @dinyar, @elusian, @eyigitba, @fabiocos, @felicepantaleo, @fioriNTU, @forthommel, @francescobrivio, @fsimone91, @gkasieczka, @gouskos, @gpetruc, @grzanka, @hatakeyamak, @idebruyn, @jainshilpi, @jandrea, @jazzitup, @jbsauvan, @jdamgov, @jdolen, @jhgoh, @kurtejung, @lecriste, @lgray, @llunerti, @makortel, @mandrenguyen, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmasciov, @mmusich, @mtosi, @nhanvtran, @pakhotin, @pavlo-kashko, @philippgadow, @ram1123, @rappoccio, @rchatter, @richa2710, @rociovilar, @rovere, @rsreds, @salimcerci, @sameasy, @schoef, @seemasharmafnal, @slomeo, @sobhatta, @sroychow, @thomreis, @threus, @tlampen, @tocheng, @trocino, @valsdav, @varuns23, @venturia, @wang0jin, @wmtford, @yenjie, @yetkinyilmaz, @yslai, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2026-01-20T22:16:05Z

assign core

cmsbuild · 2026-01-20T22:16:42Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel · 2026-01-27T16:30:40Z

-// \author David Chamont  - Laboratoire Leprince-Ringuet - �cole polytechnique, CNRS/IN2P3
-// \author Claude Charlot - Laboratoire Leprince-Ringuet - �cole polytechnique, CNRS/IN2P3
+// \author David Chamont  - Laboratoire Leprince-Ringuet - �cole polytechnique, CNRS/IN2P3
+// \author Claude Charlot - Laboratoire Leprince-Ringuet - �cole polytechnique, CNRS/IN2P3


For the final inclusion to CMSSW_20 I think we should exclude this change.

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

cmsbuild · 2026-01-27T17:35:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49881/47721

cmsbuild · 2026-01-27T17:35:42Z

Pull request #49881 was updated. @BenjaminRS, @Dr15Jones, @Martin-Grunewald, @Moanwar, @battibass, @civanch, @cmsbuild, @ftorrresd, @jfernan2, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @mkirsano, @mmusich, @quinnanm, @sensrcn, @smuzaffar, @srimanob, @theofil, @tvami can you please check and sign again.

Dr15Jones · 2026-01-27T17:35:53Z

please test

cmsbuild · 2026-01-27T19:37:58Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edbcd5/50939/summary.html
COMMIT: b4088b3
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-01-26-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49881/50939/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 10 errors in the following unit tests:

---> test testPhysicsToolsSelectorUtilsPythonTestsDriver had ERRORS
---> test testOnlineBeamMonitor had ERRORS
---> test test_ZMuMuMassConstraintParameterFinder had ERRORS
and more ...

Failed RelVals

25202.0

----- Begin Fatal Exception 27-Jan-2026 20:04:52 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

2500.3001

----- Begin Fatal Exception 27-Jan-2026 20:14:01 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Attempted to open logical file /store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class edm::reftobase::IndirectHolder<reco::Track> read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root
   has the same version (=10) as the active class but a different checksum.
   You should update the version to ClassDef(edm::reftobase::IndirectHolder<reco::Track>,11).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class edm::reftobase::IndirectHolder<reco::Track> read from file root://cms-xrd-global.cern.ch//eos/cms/store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root
   has the same version (=10) as the active class but a different checksum.
   You should update the version to ClassDef(edm::reftobase::IndirectHolder<reco::Track>,11).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root?scitag.flow=196664.
      [e] Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class edm::reftobase::IndirectHolder<reco::Track> read from file root://xrootd-cms.infn.it//store/mc/RunIII2024Summer24MiniAODv6/TTtoLNu2Q_TuneCP5_13p6TeV_powheg-pythia8/MINIAODSIM/150X_mcRun3_2024_realistic_v2-v2/2520000/00045344-a602-4022-ac1e-81161a31a314.root
   has the same version (=10) as the active class but a different checksum.
   You should update the version to ClassDef(edm::reftobase::IndirectHolder<reco::Track>,11).
   Do not try to write objects with the current class definition,
   the files will not be readable.


----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 27-Jan-2026 20:03:01 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenJet> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenJet>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenJet> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenJets_ak4GenJetsNoNu__SIM.
  recoGenJets_ak4GenJets__SIM.
  recoGenJets_ak8GenJetsNoNu__SIM.
  recoGenJets_ak8GenJets__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed AddOn Tests

pat1

----- Begin Fatal Exception 27-Jan-2026 20:00:44 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it&xrdcl.requuid=96289fef-3198-4551-932e-261636df425e
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Dr15Jones · 2026-01-27T20:17:54Z

ignore tests-rejected with manual-override

makortel · 2026-01-27T20:20:05Z

+core

The failures will be addressed separately.

tvami · 2026-01-27T22:42:33Z

+1

Moanwar · 2026-01-28T08:26:41Z

+1

ftorrresd · 2026-01-28T16:12:46Z

+1

mandrenguyen · 2026-01-28T21:44:13Z

merge

cmsbuild added reconstruction-pending simulation-pending dqm-pending l1-pending hlt-pending analysis-pending alca-pending generators-pending visualization-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending tracking trk changes-dataformats labels Jan 20, 2026

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jan 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 20, 2026

cmsbuild added the core-pending label Jan 20, 2026

cmsbuild added tests-approved tests-manual-override and removed tests-rejected labels Jan 27, 2026

makortel reviewed Jan 27, 2026

View reviewed changes

Reset class version for reco::FFTJetProducerSummary

b4088b3

Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved tests-manual-override labels Jan 27, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 27, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2026

cmsbuild added tests-rejected and removed tests-started labels Jan 27, 2026

cmsbuild added tests-approved and removed tests-rejected labels Jan 27, 2026

This was referenced Feb 24, 2026

[EVO] Fix merge conflict in GsfTracking classes_def.xml #50242

Merged

[EVO] Moved data products in to io_v1 namespace #50230

Merged

Conversation

Dr15Jones commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

makortel commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

makortel Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmsbuild commented Jan 27, 2026

Uh oh!

cmsbuild commented Jan 27, 2026

Uh oh!

Dr15Jones commented Jan 27, 2026

Uh oh!

cmsbuild commented Jan 27, 2026

Failed Unit Tests

Failed RelVals

Failed AddOn Tests

Uh oh!

Dr15Jones commented Jan 27, 2026

Uh oh!

makortel commented Jan 27, 2026

Uh oh!

tvami commented Jan 27, 2026

Uh oh!

Moanwar commented Jan 28, 2026

Uh oh!

ftorrresd commented Jan 28, 2026

Uh oh!

mandrenguyen commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Dr15Jones commented Jan 20, 2026 •

edited

Loading

cmsbuild commented Jan 20, 2026 •

edited

Loading