Remove alpaka procModfier from workflows in which it is no longer useful#49755
Remove alpaka procModfier from workflows in which it is no longer useful#49755VourMa wants to merge 3 commits into
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49755/47340
|
|
A new Pull Request was created by @VourMa for master. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
assign hlt
|
|
New categories assigned: hlt @Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
Thanks for the work on this, but I don’t think we should proceed with these changes. By removing In my view, the For these reasons, I think removing |
|
Hi @mmusich, these are valid concerns that I thought a bit about. Let me reply inline and we can discuss further:
The
I agree. As I tried to explain above, the |
|
test parameters:
|
|
59c9798 to
b10522a
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49755/47479
|
|
Pull request #49755 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @miquork, @mmusich can you please check and sign again. |
|
-1 Failed Tests: RelVals Failed RelValsValueError: Undefined workflows: 34434.7562 |
|
as the workflow family with offset |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49755/47501
|
|
Pull request #49755 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @miquork, @mmusich can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
+hlt |
|
@cms-sw/pdmv-l2 Any concerns from your side on this PR? Your signature is the only one missing. Thank you! |
|
Closing this PR, as it was left unsigned for too long and has conflicts with the more urgent #50040. It is now superseded by that PR. |
In #48921, Patatrack quadraplet pixel tracks were made the default in CMSSW, so the alpaka modifier was rendered useless in a quite a few workflows which were using it to enable Patatrack pixel tracking. This PR removes the alpaka procModifier from these workflows. One workflow is completely removed, as it was duplicate of another, and that leads to a small change in the workflow numbering.
The PR was validated by making sure that all the modified workflows succeed.
FYI @rovere and @waredjeb: Since the
alpakaprocModifier is used in Phase 2 HLT to enable the HGCal heterogeneous reconstruction, I wanted to ask whether it is useful to keep it in any of the modified workflows.