Skip to content

pass extra options to das_cache.py for proper caching of das results#2681

Merged
smuzaffar merged 3 commits into
masterfrom
das_cache-extra-opts
Feb 12, 2026
Merged

pass extra options to das_cache.py for proper caching of das results#2681
smuzaffar merged 3 commits into
masterfrom
das_cache-extra-opts

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

@smuzaffar smuzaffar commented Feb 11, 2026

This change allow to capture extra options of dasgo client e.g. --limit N and/or -unique can properly record it for das caching job so that same option can be used to cache the results

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented Feb 11, 2026

please test with cms-sw/cmssw#50118

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 11, 2026

A new Pull Request was created by @smuzaffar for branch master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 11, 2026 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 11, 2026

Pull request #2681 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 11, 2026

Pull request #2681 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented Feb 12, 2026 •
edited
Loading

please test with cms-sw/cmssw#50118

@smuzaffar
Copy link
Copy Markdown
Contributor Author

smuzaffar commented Feb 12, 2026

+externals

looks good

@smuzaffar smuzaffar merged commit 35bc052 into master Feb 12, 2026
8 of 10 checks passed
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 12, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#50118

@cmsbuild cmsbuild mentioned this pull request Feb 12, 2026
Merged
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 12, 2026

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-de6e0d/51280/summary.html
COMMIT: 4fbfe1e
CMSSW: CMSSW_16_1_X_2026-02-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2681/51280/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Failed RelVals

  • 2025.00000012025.0000001_RunZeroBias2025B_10k/step2_RunZeroBias2025B_10k.log
  • 2025.0010001DAS Error

Failed RelVals-INPUT

  • 2023.0000001DAS Error
  • 2023.00100012023.0010001_RunEGamma02023C_10k/step2_RunEGamma02023C_10k.log
  • 2022.0000001DAS Error
Expand to see more relval errors ...

@smuzaffar smuzaffar deleted the das_cache-extra-opts branch March 23, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-approved fully-signed orp-pending requires-external tests-rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuzaffar @cmsbuild