New edition of process_pr

[iarspider]

@smuzaffar as discussed today. I have put new code into new file (process_pr_v2.py), will replace old process_pr before merging.

It doesn't yet do everything - for example, it won't detect when tests are complete, I will implement it later.

We can also use this opportunity to implement our own handling of commit statuses (I have a draft cgi handler for this) that we should discuss offline.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[cmsbuild]

Pull request #2626 was updated.

[smuzaffar]

@iarspider , does new bot properly check for api_rate_limits?

[iarspider]

@smuzaffar not exactly. I was assuming that PyGithub handles that "under the hood", but after examining the library code I see that it only reacts to limit being exceeded. I will prepare and push a change to add a few rate limit checks in critical places.

[iarspider]

I have squased the PR, will work on rate limit later.

[smuzaffar]

@raoatifshad , I see in jenkins job https://cmssdt.cern.ch/jenkins/job/cms-bot/1945425/console

process_pr_v2.py:5804 [INFO] Removing labels: ['code-checks-pending', 'tests-pending']
process_pr_v2.py:5816 [WARNING] Could not remove labels ['code-checks-pending', 'tests-pending']: remove_from_labels() takes 2 positional arguments but 3 were given
process_pr_v2.py:7096 [INFO] PR state: signatures-pending
process_pr_v2.py:6202 [DEBUG] Pre-check code-checks already has status, skipping auto-trigger
process_pr_v2.py:7135 [INFO] Creating code-checks properties file (manual request)
process_pr_v2.py:6027 [INFO] Creating properties file: trigger-code-checks-cms-sw-cmssw-49771.properties
process_pr_v2.py:2365 [DEBUG] Status cms/49771/code-checks unchanged, skipping update
process_pr_v2.py:1144 [DEBUG] Cache comment 1/1 unchanged, skipping

can you please check if bot has seen Pre-check code-checks already has status, skipping auto-trigger then why it still does Creating code-checks properties file (manual request) ?

[smuzaffar]

FYI @iarspider #2626 (comment) (new bot is keep on triggering code-checks for cms-sw/cmssw#49771 )

[smuzaffar]

For now I have added <cmsbot></cmsbot> in the cms-sw/cmssw#49771 PR description so that bot does not run for it (and avoid resursive code-checks)

[iarspider]

Checking.