Skip to content

Security: Command injection risk in global teardown process-kill commands #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Security: Command injection risk in global teardown process-kill commands #5299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions e2e/global-teardown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { execSync } from 'child_process';
import { execFileSync } from 'child_process';

const BACKEND_PORT = process.env.BACKEND_PORT || '5543';

Expand All @@ -13,11 +13,15 @@ const BACKEND_PORT = process.env.BACKEND_PORT || '5543';
* A single pkill pattern matches both.
*/
async function globalTeardown() {
if (!/^\d{2,5}$/.test(BACKEND_PORT)) {
return;
}

const pattern = `e2e:${BACKEND_PORT}`;
try {
const pids = execSync(`pgrep -f '${pattern}'`, { encoding: 'utf8' }).trim();
const pids = execFileSync('pgrep', ['-f', pattern], { encoding: 'utf8' }).trim();
if (pids) {
execSync(`pkill -f '${pattern}'`);
execFileSync('pkill', ['-f', pattern]);
console.log(` Stopped e2e test servers (session ${BACKEND_PORT}).`);
}
} catch {
Expand Down