Revert windows inigo fixes and pin the codependency tests to just linux#1139
Merged
Conversation
This reverts commit 76235f3.
This reverts commit ae92f70.
This reverts commit 6bb789d.
This reverts commit 968c4a4.
Add //go:build !windows build tags to prevent compilation and testing on Windows platforms. This resolves syscall.Kill compatibility issues while maintaining full functionality on Linux/Unix systems. Files excluded from Windows builds: - codependency_test.go (integration tests) - fake_app_test.go and fake_proxy_test.go (unit tests) - fake_app/main.go and fake_proxy/main.go (test assets) VMTA-TEST-123 ai-assisted=yes Co-authored-by: Cursor <cursoragent@cursor.com>
ameowlia
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows signal handling and exit code handling are significantly different from the linux model used to write the tests. Since the underlying code in executor is agnostic, we can ignore the inigo tests on windows.
Backward Compatibility
Breaking Change? no