[Artifacts] Add Wrangler commands documentation#30827
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
github-actions
Bot
assigned
dmmulroy,
elithrar,
mattzcarey,
whoiskatrin,
irvinebroque,
GregBrimble,
MattieTK,
mikenomitch and
WalshyDev
ask-bonk
Bot
added
documentation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 suggestions posted inline.
MEDIUM — InlineBadge preset="beta" text="Private beta" renders as "Beta" because the preset overrides the text prop. Use variant="caution" instead if you want "Private beta".
LOW — Unused Render import in the partial.
Also note: the documentation checklist leaves the changelog entry unchecked. If this feature is customer-facing, consider adding one so it surfaces in RSS/Discord.
|
|
||
| import { Render, InlineBadge } from "~/components"; | ||
|
|
||
| Manage [Artifacts](/artifacts/) namespaces, repositories, and repo-scoped tokens using Wrangler. <InlineBadge preset="beta" text="Private beta" /> |
There was a problem hiding this comment.
<InlineBadge> overrides text when preset is set. To display "Private beta", remove preset:
| Manage [Artifacts](/artifacts/) namespaces, repositories, and repo-scoped tokens using Wrangler. <InlineBadge preset="beta" text="Private beta" /> | |
| Manage [Artifacts](/artifacts/) namespaces, repositories, and repo-scoped tokens using Wrangler. <InlineBadge text="Private beta" variant="caution" /> |
| {} | ||
| --- | ||
|
|
||
| import { Render, AnchorHeading, Type, MetaInfo } from "~/components"; |
There was a problem hiding this comment.
Remove unused import:
| import { Render, AnchorHeading, Type, MetaInfo } from "~/components"; | |
| import { AnchorHeading, Type, MetaInfo } from "~/components"; |
|
Done. Here's the review summary for PR #30827: Labels applied: Findings:
What passes:
|
irvinebroque
left a comment
irvinebroque
left a comment
There was a problem hiding this comment.
include changelog but otherwise lgtm
| {} | ||
| --- | ||
|
|
||
| import { Render, AnchorHeading, Type, MetaInfo } from "~/components"; |
There was a problem hiding this comment.
Is there a reason you aren't doing this via WranglerCommand and/or WranglerNamespace components directly?
You may need to bump wrangler version in docs for this to work.
|
Addressed all feedback in the latest push:
|
- Add wrangler commands reference page at workers/wrangler/commands/artifacts - Add wrangler commands page at artifacts/api/wrangler using shared partial - Fix InlineBadge to use variant=caution so Private beta text renders - Remove unused Render import from partial - Add changelog entry for May 15
dinasaur404
force-pushed
the
artifacts-wrangler-commands
branch
from
2f0b786 to
c326d80
Compare
|
Updated — dropped the wrangler version bump and switched back to the Merge conflict is also resolved — rebased onto production. |
| @@ -0,0 +1,21 @@ | |||
| --- | |||
| title: Wrangler support for Artifacts | |||
11 participants
Summary
Adds reference documentation for Artifacts Wrangler CLI commands. Users can now manage Artifacts namespaces, repositories, and repo-scoped tokens from the command line.
src/content/docs/workers/wrangler/commands/artifacts.mdx— Wrangler commands reference under the Workers sectionsrc/content/docs/artifacts/api/wrangler.mdx— Wrangler commands reference under the Artifacts API sectionsrc/content/partials/workers/wrangler-commands/artifacts.mdx— Shared partial with command details, options, and examplesScreenshots (optional)
Documentation checklist