Declare permissions on the release workflows#382
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Both manual-release.yml and scheduled-release.yml run release.sh (which can push a release branch) and use repo-sync/pull-request to open a PR against master with GITHUB_TOKEN. Granting contents: write + pull-requests: write at the workflow level captures the actual write scopes used; the rest of the steps (build, Google Chat notification) need no extra GitHub API scopes. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Author
|
I have read the CLA Document and I hereby sign the CLA |
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
4f1a179 to
e33f397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit top-level
permissionsblocks to the two release workflows so the defaultGITHUB_TOKENonly carries the scopes those workflows actually use:The Google Chat notification step uses
SSL_TEAM_GOOGLE_CHAT_WEBHOOK, notGITHUB_TOKEN, so it doesn't need any additional scopes. The siblingsemgrep.ymlis already hardened. YAML validated locally.