Conversation
johnhurt
approved these changes
Apr 23, 2026
cjpatton
approved these changes
Apr 25, 2026
Collaborator
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
This is unfortunate but seems relatively harmless. Sometimes you just have to match OpenSSL.
Note that OpenSSL can be configured to be as strict as BoringSSL here, but is not configured this way by default. See X509_V_FLAG_X509_STRICT in https://docs.openssl.org/master/man3/X509_VERIFY_PARAM_set_flags/#description
Co-authored-by: Christopher Patton <cpatton@cloudflare.com>
Contributor
|
Where did we land on this one? I was operating under the assumption that it was already merged 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by Pingora to unfork boring.