Skip to content

AB-2990 Add RECORD_AUDIO, MODIFY_AUDIO_SETTINGS permission for sites using mic #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayeshsolanki93 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AB-2990 Add RECORD_AUDIO, MODIFY_AUDIO_SETTINGS permission for sites using mic #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db0e92c
AB-2990 Add RECORD_AUDIO, MODIFY_AUDIO_SETTINGS permission for sites …
jayeshsolanki93 Dec 17, 2019
709ad37
Notify the permission request that it was denied
jayeshsolanki93 Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.CAMERA"
android:required="false" />
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
<uses-permission tools:node="remove" android:name="android.permission.READ_PHONE_STATE" />

Expand Down
20 changes: 18 additions & 2 deletions app/src/main/java/acr/browser/lightning/view/LightningChromeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import com.cliqz.browser.main.Messages;
import com.cliqz.nove.Bus;

import java.util.ArrayList;
import java.util.List;
import java.util.Locale;

import javax.inject.Inject;
Expand Down Expand Up @@ -94,6 +96,19 @@ public void onReceivedIcon(WebView view, Bitmap icon) {

@Override
public void onPermissionRequest(PermissionRequest request) {
List<String> permissions = new ArrayList<>();
for (String requestedPermission : request.getResources()) {
switch (requestedPermission) {
case "android.webkit.resource.VIDEO_CAPTURE":
permissions.add(Manifest.permission.CAMERA);
break;
case "android.webkit.resource.AUDIO_CAPTURE":
permissions.add(Manifest.permission.RECORD_AUDIO);
break;
default:
break;
}
}
activity.runOnUiThread(() -> PermissionsManager.getInstance()
.requestPermissionsIfNecessaryForResult(activity, new PermissionsResultAction() {
@Override
Expand All @@ -103,9 +118,10 @@ public void onGranted() {

@Override
public void onDenied(String permission) {
// no-op
Timber.i("The permission was denied by the user");
request.deny();
}
}, Manifest.permission.CAMERA));
}, permissions.toArray(new String[permissions.size()])));
}

@Override
Expand Down