Skip to content

Use GetLatestSnapshot in CleanupRecordExists #8594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfc-gh-mslot wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Use GetLatestSnapshot in CleanupRecordExists #8594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/backend/distributed/operations/shard_cleaner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,10 +1192,14 @@ CleanupRecordExists(uint64 recordId)
ScanKeyInit(&scanKey[0], Anum_pg_dist_cleanup_record_id,
BTEqualStrategyNumber, F_INT8EQ, Int64GetDatum(recordId));

/* make sure we can always see deletion after acquiring the operation ID lock */
Copy link
Copy Markdown
Contributor

@colm-mchugh colm-mchugh May 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment format strays from convention. Maybe add this text to the function comment at line 1179 ?

Snapshot snapshot = GetLatestSnapshot();

SysScanDesc scanDescriptor = systable_beginscan(pgDistCleanup,
DistCleanupPrimaryKeyIndexId(),
indexOK,
NULL, scanKeyCount, scanKey);
snapshot,
scanKeyCount, scanKey);

HeapTuple heapTuple = systable_getnext(scanDescriptor);
bool recordExists = HeapTupleIsValid(heapTuple);
Expand Down
Loading