Backport: fix unregistered snapshot crash and keep temp reloid for columnar#8503
Merged
Conversation
PG18 added an assertion that a snapshot is active or registered before it's used. Relevant PG commit postgres/postgres@8076c00 Fixes #8209
Fixes #8235 PG18 and PG latest minors ignore temporary relations in `RelidByRelfilenumber` (`RelidByRelfilenode` in PG15) Relevant PG commit: postgres/postgres@86831952 Here we are keeping temp reloids instead of getting it with RelidByRelfilenumber, for example, in some cases, we can directly get reloid from relations, in other cases we keep it in some structures. Note: there is still an outstanding issue with columnar temp tables in concurrent sessions, that will be fixed in PR #8252
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-13.2 #8503 +/- ##
================================================
- Coverage 88.91% 88.90% -0.01%
================================================
Files 287 287
Lines 63220 63227 +7
Branches 7956 7957 +1
================================================
+ Hits 56213 56214 +1
- Misses 4679 4683 +4
- Partials 2328 2330 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following commits into release-13.2: