Fix joaat mixup for RemoveCurrentRise#732
Open
chipjpg wants to merge 2 commits into
Open
Conversation
Changed joaat from 0x7DBCEF6F to 0x45268B6F. 0x7DBCEF6F was used to reset the rise counter to 0 on console. afaik it's not available on new builds.
|
0x45268B6F = REMOVE_EXTRA_CALMING_QUAD |
stannum-cfx
added
the
needs validation
Contributor
|
I'm not sure how to verify if this won't break anything, @blattersturm any ideas? |
Collaborator
|
I don't think jooat values are used for anything besides documenting if a name is valid or not, which this also fixes. I'll double check to make sure this does break anything before merging |
AvarianKnight
added
merging-blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed joaat from 0x7DBCEF6F to 0x45268B6F.
0x7DBCEF6F was used to reset the calming quad counter to 0 on console. afaik it's not available on new builds.