fix(server/resources): decode percent-encoded resource name from URI fragment#4002
Closed
lucienlmy wants to merge 1 commit into
Closed
fix(server/resources): decode percent-encoded resource name from URI fragment#4002lucienlmy wants to merge 1 commit into
lucienlmy wants to merge 1 commit into
Conversation
Resource names from URI fragments were not decoded back from percent-encoding, causing non-ASCII resource names (e.g. Chinese) to be registered as encoded strings like "%E8%B7%91%E9%85%B7". This resulted in: - `ensure <resource>` unable to find resources with non-ASCII names - Garbled resource names in console warnings/errors The path component already calls `skyr::percent_decode()`, but the fragment (used as the resource name) was missing the same treatment. Adding it makes the encode/decode cycle symmetric.
github-actions
Bot
added
the
invalid
lucienlmy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource names from URI fragments were not decoded back from
percent-encoding, causing non-ASCII resource names (e.g. Chinese)
to be registered as encoded strings like "%E8%B7%91%E9%85%B7".
This resulted in:
ensure <resource>unable to find resources with non-ASCII namesThe path component already calls
skyr::percent_decode(), but thefragment (used as the resource name) was missing the same treatment.
Adding it makes the encode/decode cycle symmetric.