fix(gta-core-five): validate instance archetypes of manifold contact points#3990
Open
DaniGP17 wants to merge 1 commit into
Open
fix(gta-core-five): validate instance archetypes of manifold contact points#3990DaniGP17 wants to merge 1 commit into
DaniGP17 wants to merge 1 commit into
Conversation
github-actions
Bot
added
triage
|
up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a crash exploit related to manifold contact points, somehow they are making the archetype of a instance nullptr.
How is this PR achieving the goal
Hooking the
IterateManifoldfunction to validate instances and archetypes of the instances.This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3258
Platforms: Windows
Checklist
Fixes issues
fixes #3466
GTA5_b3258.exe+14CC990