feat(extra-natives-five): add native to restore a broken vehicle wheel#3933
Open
spacevx wants to merge 2 commits into
Open
feat(extra-natives-five): add native to restore a broken vehicle wheel#3933spacevx wants to merge 2 commits into
spacevx wants to merge 2 commits into
Conversation
Contributor
AvarianKnight
left a comment
There was a problem hiding this comment.
we should have the note that this isn't networked in the native docs.
Contributor
|
Question though, will this be restored for new players that enter the range of the vehicle or will it still be broken off? |
Contributor
Author
Will still be broken, i can still try to hook SetVehicleHealth to achieve/correct this but don't know if it's okay |
Co-authored-by: Dillon Skaggs <dillon@dillonskaggs.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Introducing a new native to restore vehicle wheels, with the native
BreakOffVehicleWheelwe didn't have a way to reattach wheel on the vehicle. Please beaware this native is not synced (compared to BreakOffVehicleWheel who is synced to others players in the onesync range)How is this PR achieving the goal
Clear the broken-off wheel state, restore the wheel health and reattach its fragment back to the vehicle, without touching other broken parts
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3258 (still needs to be tested on other gamebuilds)
Platforms: Windows
Checklist
Fixes issues
https://forum.cfx.re/t/add-native-to-reattach-vehicle-wheels-by-index/5394134
https://forum.cfx.re/t/add-a-fixwheel-native-as-the-counterpart-of-breakoffvehiclewheel/5204684