Skip to content

fix(fxdk): prevent path traversal in remote resources #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VeinDevTtv wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Draft

fix(fxdk): prevent path traversal in remote resources #3920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ext/sdk/resources/sdk-root/shell/src/backend/fxcode/fxcode-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { concurrently } from "utils/concurrently";
import { ShellBackend } from 'backend/shell-backend';
import { URL } from 'url';
import { NotificationService } from "backend/notification/notification-service";
import * as path from 'path';

interface FXCode {
getRootPath(): string;
Expand Down Expand Up @@ -68,7 +69,12 @@ export class FXCodeService implements AppContribution {

this.shellBackend.expressApp.get('/vscode-remote-resource', (req, res) => {
if (this.fxcode) {
res.sendFile(this.fxcode.getRemoteResourcePath(getUrlQuery(req.url)));
const resourcePath = this.fxcode.getRemoteResourcePath(getUrlQuery(req.url));
if (!resourcePath || !isPathInside(resourcePath, this.configService.sdkRootFXCode)) {
res.status(400).send('Invalid resource path');
return;
}
res.sendFile(resourcePath);
} else {
res.send('FXCode not started it seems, rip');
}
Expand Down Expand Up @@ -167,3 +173,11 @@ function getUrlQuery(url: string): Record<string, string> {
return acc;
}, {});
}

function isPathInside(candidate: string, root: string): boolean {
const resolvedRoot = path.resolve(root);
const resolvedCandidate = path.resolve(candidate);
const relativePath = path.relative(resolvedRoot, resolvedCandidate);

return relativePath === '' || (!!relativePath && !relativePath.startsWith('..') && !path.isAbsolute(relativePath));
}
Loading