Fix time-sensitive certificate test#464
Merged
bifurcation merged 4 commits intomainfrom Apr 11, 2026
Merged
Conversation
The "Test Certificate notBefore status" test had a certificate with notBefore = 2026-03-08, which is now in the past, causing the test to fail. Replace with a certificate that has notBefore = 2099-01-01 to ensure the test remains valid for decades. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR #424 added std::function usage but missed the include directive. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The switch case for MLKEM cipher suites used #if !defined(P256_SHA256) which is always true. This should be #if defined(WITH_PQ) to match the cipher definitions above. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The array was renamed from all_supported_suites to all_supported_cipher_suites but the interop code wasn't updated. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several issues in main that were causing CI failures:
Time-sensitive certificate test - The "Test Certificate notBefore status" test had a certificate with
notBefore = 2026-03-08, which is now in the past. Replaced with a certificate that hasnotBefore = 2099-01-01.Missing
#include <functional>- PR Support custom signing routines in SignaturePrivateKey #424 addedstd::functionusage incrypto.hbut missed the include directive.Wrong preprocessor guard for PQ cipher suites - The switch case used
#if !defined(P256_SHA256)(always true) instead of#if defined(WITH_PQ), causing build failures on non-PQ builds.Interop code using old array name - The interop code still used
all_supported_suitesinstead ofall_supported_cipher_suites.Test plan
🤖 Generated with Claude Code