Add tests for custom signing functions#462
Merged
bifurcation merged 9 commits intomainfrom Apr 13, 2026
Merged
Conversation
This enables support for signing with non-extractable private keys (e.g. TPM-bound).
- Add test wrapping an HPKE-layer private key with SignerFunc - Add macOS Keychain test using Security.framework (conditional) - Link Security.framework on macOS for Keychain tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace TLS_SERIALIZABLE with custom operators that throw on non-exportable keys - Add exportable() method to check if key can be serialized - Add tests verifying serialization throws for external signers - Add tests verifying normal keys serialize/deserialize correctly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for std::function used by SignerFunc. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5 tasks
After merging main, update test to use the renamed array. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Apply clang-format to fix code style after merging main. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Upgrade from clang-format 16 to 19 to match modern formatting. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on top of #424 to add tests demonstrating the custom signer functionality:
SecKeyCreateSignature, showing real-world HSM/secure enclave integrationTest plan
HAVE_SECURITY_FRAMEWORK)Notes
This PR depends on #424 being merged first.
🤖 Generated with Claude Code