refactor: retire scripts/ in favor of lib/ and tools/#87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the top-level
scripts/junk-drawer, sorting its contents by role instead of leaving them in a catch-all.What moved
scripts/common/ssh.sh→lib/ssh.sh— the one genuinely-shared bash helper (sourced by kiwix + status-pipeline). New top-levellib/for shared sourced code.scripts/common/{cert.sh, nas/omv.sh, nas/install-cert-remote.sh}→stacks/apps/cert-sync-nas/common/— these were used by only cert-sync-nas (and bind-mounted into its container), so the app now owns its full runtime bundle.cert-sync-nas/common/ssh.shis a vendored copy (omv.sh sources it as a co-located sibling, in-container and in tests) — this deliberately decouples the deployed container from the shared dev helper.scripts/status-pipeline/→tools/status-pipeline/,scripts/cluster-health.sh→tools/cluster-health.sh,scripts/dev/→tools/dev/— invocable tooling, sibling totools/ci.ssh_test→tests/unit/lib/,cert_test/omv_test→cert-sync-nas/tests/.scripts/no longer exists.Why
scripts/commonwas a junk drawer: 3 of its 4 files were single-owner (cert-sync-nas), not shared. Grouping by what something is (shared lib / app-owned bundle / invocable tool) removes the distance-coupling where an app reached../../../scripts/commonto mount its own code.Notable
configs:: only thefile:source paths changed (../../../scripts/common/...→./common/...). In-containertarget:paths andCOMMON_DIR=/scripts/commonare byte-identical, and file contents are unchanged — so no config-version bump needed..gitignore: added anchored negations (!/lib/,!/tests/unit/lib/) because the boilerplate Python venv-ignore (lib/) would otherwise swallow our committed source..env.example,llms.txt, docs.Verification
tests/unit/lib/+stacks/apps/*/tests/)task --listresolves thestatus-pipeline:*namespace from its new homedocker compose configfor cert-sync-nas is valid; all four bundle files resolve🤖 Generated with Claude Code