Quality: removeFileAtPath silently corrupts file tree when file not found (splice with index -1)#606
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…when file not found (splice with index -1)
When the target file does not exist at the given path, `getChildFileFromName` returns `{index: -1, file: undefined}`. The destructured `index` is -1, and `currentFolder.splice(-1, 1)` silently removes the **last** item in the array instead of the intended file. This is silent data corruption — the user deletes a nonexistent path and loses an unrelated file.
Affected files: fileUtils.js
Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
When the target file does not exist at the given path,
getChildFileFromNamereturns{index: -1, file: undefined}. The destructuredindexis -1, andcurrentFolder.splice(-1, 1)silently removes the last item in the array instead of the intended file. This is silent data corruption — the user deletes a nonexistent path and loses an unrelated file.Severity:
criticalFile:
src/fileUtils.jsSolution
When the target file does not exist at the given path,
getChildFileFromNamereturns{index: -1, file: undefined}. The destructuredindexis -1, andcurrentFolder.splice(-1, 1)silently removes the last item in the array instead of the intended file. This is silent data corruption — the user deletes a nonexistent path and loses an unrelated file.Changes
src/fileUtils.js(modified)Testing
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #605