Update rclone to 1.74.3

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
       androidArch: x86_64
     steps:
       - name: Check out repository
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
         with:
           submodules: true
 

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
           echo "version=${version}" >> "${GITHUB_OUTPUT}"
 
       - name: Check out repository
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
 
       - name: Create release
         uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0

app/src/main/java/com/chiller3/rsaf/rclone/Authorizer.kt

@@ -156,6 +156,7 @@ object Authorizer {
                     if (line.contains(MARKER_CODE_START)) {
                         inCode = true
                     } else if (line.contains(MARKER_CODE_STOP)) {
+                        @Suppress("AssignedValueIsNeverRead")
                         inCode = false
                         listener.onAuthorizeCode(code.toString())
                         break

app/src/main/java/com/chiller3/rsaf/rclone/KeepAliveService.kt

@@ -1,5 +1,5 @@
 /*
- * SPDX-FileCopyrightText: 2024-2025 Andrew Gunnerson
+ * SPDX-FileCopyrightText: 2024-2026 Andrew Gunnerson
  * SPDX-License-Identifier: GPL-3.0-only
  */
 
@@ -102,6 +102,7 @@ class KeepAliveService : Service() {
 
         synchronized(monitorThread) {
             monitorState = MonitorState.STOPPED
+            @Suppress("PLATFORM_CLASS_MAPPED_TO_KOTLIN")
             (monitorThread as Object).notify()
         }
 
@@ -208,6 +209,7 @@ class KeepAliveService : Service() {
                     }
                 }
 
+                @Suppress("PLATFORM_CLASS_MAPPED_TO_KOTLIN")
                 (monitorThread as Object).wait(1000)
             }
         }

app/src/main/java/com/chiller3/rsaf/rclone/RcloneProvider.kt

@@ -5,6 +5,7 @@
 
 package com.chiller3.rsaf.rclone
 
+import android.annotation.SuppressLint
 import android.content.BroadcastReceiver
 import android.content.Context
 import android.content.Intent
@@ -148,6 +149,8 @@ class RcloneProvider : DocumentsProvider(), SharedPreferences.OnSharedPreference
                 Log.w(TAG, "Truncating dynamic shortcuts from $rank to $maxShortcuts")
             }
 
+            // We can't report usage because the shortcut opens DocumentsUI directly.
+            @SuppressLint("ReportShortcutUsage")
             if (!ShortcutManagerCompat.setDynamicShortcuts(context, shortcuts)) {
                 Log.w(TAG, "Failed to update dynamic shortcuts")
             }

app/src/main/java/com/chiller3/rsaf/settings/EditRemoteScreen.kt

@@ -385,11 +385,9 @@ private fun EditRemoteContent(
                     else -> throw IllegalStateException("Invalid reason: $reason")
                 }
 
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsWarningDialog = null
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsWarningDialog = null
             }
         )
@@ -406,11 +404,9 @@ private fun EditRemoteContent(
                     else -> throw IllegalStateException("Invalid action: $action")
                 }
 
-                @Suppress("AssignedValueIsNeverRead")
                 showRemoteNameDialog = null
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showRemoteNameDialog = null
             },
         )
@@ -422,11 +418,9 @@ private fun EditRemoteContent(
             initialOptions = state.config?.vfsOptions!!,
             onSelect = { options, reload ->
                 onVfsOptionsChange(options, reload)
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsOptionsDialog = false
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsOptionsDialog = false
             },
         )

app/src/main/java/com/chiller3/rsaf/settings/ErrorDetailsDialog.kt

@@ -25,6 +25,7 @@ import com.chiller3.rsaf.R
 fun ErrorDetailsDialog(
     message: String?,
     onDismiss: () -> Unit,
+    showCopy: Boolean = true,
 ) {
     val context = LocalContext.current
 
@@ -46,7 +47,7 @@ fun ErrorDetailsDialog(
             }
         },
         dismissButton = {
-            message?.let {
+            if (message != null && showCopy) {
                 TextButton(
                     onClick = {
                         val clipboardManager = context.getSystemService(ClipboardManager::class.java)

app/src/main/java/com/chiller3/rsaf/settings/InteractiveConfigurationScreen.kt

@@ -222,7 +222,6 @@ private fun InteractiveConfigurationContent(
             input.edit {
                 replace(0, length, currentOrDefault)
             }
-            @Suppress("AssignedValueIsNeverRead")
             loadedOnce = true
         }
     }
@@ -338,11 +337,9 @@ private fun InteractiveConfigurationContent(
             cmd = cmd,
             onReceive = {
                 input.edit { replace(0, length, it) }
-                @Suppress("AssignedValueIsNeverRead")
                 showAuthorizeDialog = null
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showAuthorizeDialog = null
             },
         )

app/src/main/java/com/chiller3/rsaf/settings/SettingsScreen.kt

@@ -646,11 +646,9 @@ private fun SettingsContent(
                     else -> throw IllegalStateException("Invalid reason: $reason")
                 }
 
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsWarningDialog = null
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showVfsWarningDialog = null
             }
         )
@@ -662,11 +660,9 @@ private fun SettingsContent(
             existingRemotes = remotes.map { it.name },
             onSelect = { name ->
                 onRemoteAdd(name)
-                @Suppress("AssignedValueIsNeverRead")
                 showRemoteNameDialog = null
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showRemoteNameDialog = null
             },
         )
@@ -677,11 +673,9 @@ private fun SettingsContent(
             initialTimeout = inactivityTimeout,
             onSelect = { timeout ->
                 onInactivityTimeoutChange(timeout)
-                @Suppress("AssignedValueIsNeverRead")
                 showInactivityTimeoutDialog = false
             },
             onDismiss = {
-                @Suppress("AssignedValueIsNeverRead")
                 showInactivityTimeoutDialog = false
             },
         )

app/src/main/java/com/chiller3/rsaf/ui/Preferences.kt

@@ -181,12 +181,14 @@ fun Preference(
 private fun PreferenceSwitch(
     checked: Boolean,
     onCheckedChange: ((Boolean) -> Unit)?,
+    modifier: Modifier = Modifier,
     enabled: Boolean = true,
     switchColors: SwitchColors = PreferenceDefaults.switchColors(),
 ) {
     Switch(
         checked = checked,
         onCheckedChange = onCheckedChange,
+        modifier = modifier,
         enabled = enabled,
         thumbContent = {
             Icon(

gradle/libs.versions.toml

@@ -11,7 +11,7 @@ androidx-preference = "1.2.1"
 androidx-test-espresso-core = "3.7.0"
 jgit = "7.6.0.202603022253-r"
 junit = "1.3.0"
-kotlin = "2.3.21"
+kotlin = "2.4.0"
 material = "1.14.0"
 spotbugs = "4.9.8"
 tink-android = "1.21.0"