better naming for ip4-only PR #919#956
Merged
hpk42 merged 1 commit intoipv4-only-retryfrom May 8, 2026
Merged
Conversation
…so for ipv4 relays "[1.2.3.4]" and introduce config.ipv4_relay and config.mail_domain_bare helpers.
j4n
approved these changes
May 8, 2026
Contributor
j4n
left a comment
j4n
left a comment
There was a problem hiding this comment.
Indeed much more readable. Tested deploying v4-only and with domain.
missytake
approved these changes
May 8, 2026
Contributor
missytake
left a comment
missytake
left a comment
There was a problem hiding this comment.
Yeah, I guess we can also do it like this.
| -o milter_macro_daemon_name=ORIGINATING | ||
| -o cleanup_service_name=authclean | ||
| {% if config.mail_domain == config.mail_domain_deliverable %} -o smtpd_milters=unix:opendkim/opendkim.sock | ||
| {% if not config.ipv4_relay %} -o smtpd_milters=unix:opendkim/opendkim.sock |
Contributor
There was a problem hiding this comment.
yeah, that's much prettier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retain "config.mail_domain" as the domain part of @ email addresses which means for ipv4 relays "[1.2.3.4]"
and introduce config.ipv4_relay, config.postfix_myhostname and config.mail_domain_bare helpers.
i found the multiple "mail_domain*" names confusing and think the new names make several places read better.