Skip to content

fix(dns): query correct NS if MNAME server is hidden#954

Merged
missytake merged 6 commits intomainfrom
authoritative-ns-851
May 8, 2026
Merged

fix(dns): query correct NS if MNAME server is hidden#954
missytake merged 6 commits intomainfrom
authoritative-ns-851

Conversation

@missytake
Copy link
Copy Markdown
Contributor

replaces #870
fix #851

@missytake missytake requested a review from hpk42 May 7, 2026 12:18
hpk42

This comment was marked as off-topic.

Comment thread cmdeploy/src/cmdeploy/remote/rdns.py Outdated
Comment thread cmdeploy/src/cmdeploy/remote/rdns.py Outdated
@missytake
Copy link
Copy Markdown
Contributor Author

Somehow, cmlxc's DNS server doesn't behave like the real world domain zones I tested: https://github.com/chatmail/relay/actions/runs/25497765487/job/74822162260?pr=954

If anyone can dig into this, I'll get to it tomorrow the soonest

Comment thread cmdeploy/src/cmdeploy/remote/rdns.py
@hpk42 hpk42 dismissed their stale review May 7, 2026 13:28

sorry, was not meant to be posted.

@hpk42 hpk42 force-pushed the authoritative-ns-851 branch from 64385f2 to 529d071 Compare May 7, 2026 16:54
@hpk42
Copy link
Copy Markdown
Contributor

hpk42 commented May 7, 2026

added a commit changing the cmlxc-version to 0.13.5 which fixes a problem with powerdns recursor getting confused resolving NS records for subdomains, as done in this PR. DNS is really hard.

Copy link
Copy Markdown
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@missytake missytake merged commit ee435a7 into main May 8, 2026
6 checks passed
@missytake missytake deleted the authoritative-ns-851 branch May 8, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS check during deployment is not working with desec.io as upstream DNS(SEC) provider

2 participants