fix: Don't add a tombstone for a reaction if the original message didn't arrive yet#8225
Draft
fix: Don't add a tombstone for a reaction if the original message didn't arrive yet#8225
Conversation
…sage isn't found A reaction may arrive earler than the referenced message in case of multi-transport. By not creating a tombstone we still can receive it later on another transport.
…dc instance isn't found
…message isn't found
This way if the self-MDN isn't applied successfully, it can be received again and retried.
Collaborator
|
This approach leads to adding bool return flags to several functions, that's why it's common to use typed errors or error codes (e.g. in C) instead. Another option is to not add a tombstone in the default code path, but in separate paths after all necessary checks are done, but probably that will be even more complex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #8181