ceph-dev-pipeline: check shaman for "are there binaries" - #2477
Closed
dmick wants to merge 2 commits into
Closed
Conversation
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
3 times, most recently
from
October 28, 2025 18:47
f2341ae to
aed8cbe
Compare
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
from
November 13, 2025 00:39
aed8cbe to
fb0e5ef
Compare
dmick
marked this pull request as ready for review
November 13, 2025 00:39
Member
Author
|
If this looks like a sane approach I will run some test builds |
djgalloway
reviewed
Nov 13, 2025
djgalloway
reviewed
Nov 13, 2025
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
from
November 13, 2025 21:55
1ada779 to
9f7675a
Compare
Contributor
|
Can you push this to 2.jenkins and run a test build |
Member
Author
|
oh absolutely I'll test; testing on a branch now: https://jenkins.ceph.com/job/ceph-dev-pipeline/1797/ |
Checking chacra isn't the right check, since this build's chacra url is not necessarily the prior successful build's chacra url (there are multiple chacra instances). Instead, check shaman to see if there is a built repo; if so, the build can be skipped. build_container will search shaman again to find the repo url to use to build the container, if necessary. Signed-off-by: Dan Mick <dan.mick@redhat.com>
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
4 times, most recently
from
November 14, 2025 01:55
7fcc664 to
d3c383d
Compare
Signed-off-by: Dan Mick <dan.mick@redhat.com>
dmick
force-pushed
the
pipeline-use-shaman-for-built-check
branch
from
November 14, 2025 02:39
d3c383d to
7e11a9f
Compare
Member
Author
|
caught up in quoting hell. I think I'm making progress. |
Member
Author
|
well I think I have the syntax for the curl | jq right now, but it's exposed another problem: https://github.com/ceph/ceph-build/blob/main/scripts/build_container#L16-L24 when we skip the build with this mechanism, CI_COMPILE is not turned off, so the test above still tests for jenkins_build_url matching the current build URL, which is no more true than it is when CI_COMPILE is off. I need to ponder what the extra test, if any, needs to be, with a fresher mind. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking chacra isn't the right check, since this build's chacra url is not necessarily the prior successful build's chacra url (there are multiple chacra instances). Instead, check shaman to see if there is a built repo; if so, the build can be skipped. build_container will search shaman again to find the repo url to use to build the container, if necessary.
(so far completely untested; put up here for discussion)