fix: strip BlobTx wrappers in ExecCommitBlock during crash replay (backport #2846)#2935
Merged
rootulp merged 2 commits intov0.39.x-celestiafrom Apr 17, 2026
Merged
Conversation
) Fixes https://dashboard.hackenproof.com/manager/companies/celestia/celestia/reports/CELESTIA-215 ## Summary - `ExecCommitBlock` (used during crash recovery replay) was sending raw BlobTx-wrapped transactions to `FinalizeBlock`, while `applyBlock` (normal execution) strips the wrappers and sends only inner transactions - This inconsistency causes the application to compute a different `AppHash` during replay, preventing recovery when the app is multiple blocks behind the store - Added the same BlobTx stripping loop from `applyBlock` to `ExecCommitBlock` ## Test plan - [x] Added `TestExecCommitBlockBlobTxStripping` that verifies both `ApplyBlock` and `ExecCommitBlock` send identical transaction bytes to `FinalizeBlock` - [ ] Existing `TestFinalizeBlockValidators` and `TestApplyBlock` tests continue to pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/celestiaorg/celestia-core/pull/2846" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit f73b81b)
mergify
Bot
requested review from
evan-forbes,
mcrakhman,
ninabarbakadze and
rach-id
as code owners
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ninabarbakadze
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://dashboard.hackenproof.com/manager/companies/celestia/celestia/reports/CELESTIA-215
Summary
ExecCommitBlock(used during crash recovery replay) was sending raw BlobTx-wrapped transactions toFinalizeBlock, whileapplyBlock(normal execution) strips the wrappers and sends only inner transactionsAppHashduring replay, preventing recovery when the app is multiple blocks behind the storeapplyBlocktoExecCommitBlockTest plan
TestExecCommitBlockBlobTxStrippingthat verifies bothApplyBlockandExecCommitBlocksend identical transaction bytes toFinalizeBlockTestFinalizeBlockValidatorsandTestApplyBlocktests continue to pass🤖 Generated with Claude Code
This is an automatic backport of pull request #2846 done by [Mergify](https://mergify.com).