TPE: Use `value.get_as_x` methods when available by luxas · Pull Request #2323 · cedar-policy/cedar

luxas · 2026-04-22T18:01:24Z

Description of changes

Broken out from #2162

Using the get_as_x methods in TPE minimizes the delta to the concrete evaluator (which uses them), and gives us automatically (later) the right error types for type mismatches (which should not happen if the Residual is validated, but anyways).

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

Does not require updates because my change does not impact the Cedar language specification.

john-h-kastner-aws

Change is good, but I feel like it could probably be more aggressive

github-actions · 2026-04-22T18:28:53Z

Coverage Report

Head Commit: b471c2d4aed133a4295b2f0fad5f6eec0f46373d

Base Commit: c50137867110c87b8e7e2c80ea603a9542197c72

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 75.00%

Status: FAILED ❌

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/tpe/evaluator.rs	🟡	15/20	75.00%	103, 150, 201, 216, 238

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 87.70%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4722/5102	92.55%	--
cedar-policy	🟡	4247/5352	79.35%	--
cedar-policy-cli	🟡	1222/1614	75.71%	--
cedar-policy-core	🟢	23963/27241	87.97%	--
cedar-policy-formatter	🟢	914/1088	84.01%	--
cedar-policy-symcc	🟢	6760/7270	92.98%	--
cedar-wasm	🔴	0/28	0.00%	--

luxas · 2026-04-29T10:14:01Z

Answered in #2323 (comment):

I held off at first, as it actually introduced a small change: before, && was left as-is, now && => && . However, this is kinda expected anyways, and should never happen on validated residuals.

Left are only the Residual::Concrete matches against HasAttr and GetAttr, which either match an entity or record, I think it makes the most sense to leave those as-is, as the concrete evaluator also uses similar match statements, and then if none of them match, return a custom type_error

However, now I updated the RHS matching for And and Or to use get_as_bool as well, and improved the and and or tests to follow the same order as the match statements, such that we cover all cases exhaustively (some small edge cases were not covered before, I checked the coverage report). Also using insta to assert inner structure of the residual, this could be done for other TPE tests as well in a follow-up.

luxas · 2026-04-29T10:15:48Z

+                            },
+                            // Cannot simplify "<left-residual> && <right-residual>" or "<left-residual> && <error>"
+                            // The latter expression could become a Residual::PartialError later.
+                            Residual::Partial { .. } | Residual::Error(_) => {


using the explicit notion here instead of _ for reader clarity.

github-actions · 2026-04-29T10:24:18Z

Coverage Report

Head Commit: c44bd6e8b415b84545561609e6ac555e888522b9

Base Commit: a2756b66050db5fdc6423933441939cb57ee566e

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 90.00%

Status: PASSED ✅

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/tpe/evaluator.rs	🟢	45/50	90.00%	103, 149, 199, 214, 236

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 87.73%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4722/5102	92.55%	92.55%
cedar-policy	🟡	4247/5352	79.35%	79.35%
cedar-policy-cli	🟡	1222/1614	75.71%	75.71%
cedar-policy-core	🟢	23965/27241	87.97%	87.97%
cedar-policy-formatter	🟢	914/1088	84.01%	84.01%
cedar-policy-symcc	🟢	6769/7266	93.16%	93.16%
cedar-wasm	🔴	0/28	0.00%	0.00%

Signed-off-by: Lucas Käldström <lucas.kaldstrom@upbound.io>

github-actions · 2026-05-06T16:09:43Z

Coverage Report

Head Commit: acfdcf9de5e68d180ebdd8c08c840ca168b75fc4

Base Commit: 844cdb54feb2875f3a9f958c4d78b514f08a327f

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 90.00%

Status: PASSED ✅

Details

File	Status	Covered	Coverage	Missed Lines
cedar-policy-core/src/tpe/evaluator.rs	🟢	45/50	90.00%	104, 150, 200, 215, 237

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 87.73%

Status: PASSED ✅

Details

Package	Status	Covered	Coverage	Base Coverage
cedar-language-server	🟢	4722/5102	92.55%	--
cedar-policy	🟡	4446/5589	79.55%	--
cedar-policy-cli	🟡	1222/1614	75.71%	--
cedar-policy-core	🟢	24324/27638	88.01%	--
cedar-policy-formatter	🟢	914/1088	84.01%	--
cedar-policy-symcc	🟢	6769/7266	93.16%	--
cedar-wasm	🔴	0/28	0.00%	--

luxas changed the title ~~TPE: Use get_as_x methods when available~~ TPE: Use value.get_as_x methods when available Apr 22, 2026

luxas force-pushed the tpe-get-as-x branch from 861d33c to b471c2d Compare April 22, 2026 18:08

john-h-kastner-aws approved these changes Apr 22, 2026

View reviewed changes

Comment thread cedar-policy-core/src/tpe/evaluator.rs Outdated

luxas force-pushed the tpe-get-as-x branch from b471c2d to c44bd6e Compare April 29, 2026 10:06

luxas requested review from john-h-kastner-aws and victornicolet April 29, 2026 10:14

luxas commented Apr 29, 2026

View reviewed changes

victornicolet reviewed Apr 29, 2026

View reviewed changes

Comment thread cedar-policy-core/src/tpe/evaluator.rs Outdated

luxas force-pushed the tpe-get-as-x branch from c44bd6e to 3cdfd39 Compare May 6, 2026 15:43

TPE: Use get_as_x methods when available

acfdcf9

Signed-off-by: Lucas Käldström <lucas.kaldstrom@upbound.io>

luxas force-pushed the tpe-get-as-x branch from 3cdfd39 to acfdcf9 Compare May 6, 2026 15:45

luxas requested a review from victornicolet May 6, 2026 15:49

victornicolet approved these changes May 6, 2026

View reviewed changes

luxas merged commit 7229edc into cedar-policy:main May 6, 2026
24 checks passed

luxas mentioned this pull request Jun 25, 2026

Rename nontrivial_residual_policies to residual_policies; residual_policies to policies #2418

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TPE: Use `value.get_as_x` methods when available#2323

TPE: Use `value.get_as_x` methods when available#2323
luxas merged 1 commit into
cedar-policy:mainfrom
luxas:tpe-get-as-x

luxas commented Apr 22, 2026

Uh oh!

john-h-kastner-aws left a comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

luxas commented Apr 29, 2026

Uh oh!

luxas Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

luxas commented Apr 22, 2026

Description of changes

Issue #, if available

Checklist for requesting a review

Uh oh!

john-h-kastner-aws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

luxas commented Apr 29, 2026

Uh oh!

luxas Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 29, 2026

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

Uh oh!

github-actions Bot commented May 6, 2026

Coverage Report

Coverage of Added or Modified Lines of Rust Code

Coverage of All Lines of Rust Code

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants