Update TPE DRT for API changes#973
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Cedar DRT TPE fuzz comparison helper to match recent cedar-policy TPE response API changes and tightens how Rust/Lean error cases are handled during equivalence checking.
Changes:
- Switches from
satisfied_*iterators to the publictrue_*,false_*,error_*, andresidual_*policy-ID iterators for Rust TPE response comparison. - Replaces residual extraction via
residual_policies()with iteratingpolicies()and building aPolicyId -> PST Exprmap. - Makes the “both sides errored” case stricter by only accepting
FfiError::LeanBackendError(_)as an expected Lean-side error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: John Kastner <jkastner@amazon.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
john-h-kastner-aws
force-pushed
the
fix-tpe-drt
branch
from
ff9024e to
6c0a0d0
Compare
katherine-hough
approved these changes
Jun 25, 2026
katherine-hough
approved these changes
Jun 25, 2026
| let [pst::Clause::When(pst_expr)] = pst_policy.body().clauses().as_slice() else { | ||
| panic!("expected exactly one `when` clause in residual") | ||
| }; | ||
| (id, pst_expr.as_ref().clone()) |
Member
There was a problem hiding this comment.
That looks much nicer than before.
victornicolet
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
true_permits/true_forbidsinstead ofsatisfied_residual_policiescall withpoliciesFixes break caused by change in cedar-policy/cedar#2401. Also depends on cedar-policy/cedar#2418
unrelated change: made the error case comparison slightly stricter, failing on some ffi error that were previously ignored.