refactor(lua): move achievement tracking onto hooks#8537
Draft
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Draft
refactor(lua): move achievement tracking onto hooks#8537scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Conversation
Assisted-by: openai/gpt-5.4 on opencode Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Achievement tracking duplicated the existing Lua hook pipeline. Moving transition logic to Lua keeps the save payload unchanged while removes the per-achievement C++ watcher layer.
Describe the solution (The How)
on_stat_changedhook and a core Lua achievement runtime that evaluates completion and failureachievements_trackeras the save/UI wrapper and pre-activate the required statistics without per-achievement watcher objectsTesting
cmake --build --preset linux-full --target astylecmake --build --preset linux-full --target cataclysm-bn-tiles cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "[stats]"./out/build/linux-full/src/cataclysm-bn-tiles --check-mods(fails on unrelated localBackrooms-CBN-modexternal option parsing error)Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
luascope to the PR title.PR opened by gpt-5.4 high on opencode