fix: cache vehicle cargo recharge targets#8521
Draft
scarf005 wants to merge 2 commits intocataclysmbn:mainfrom
Draft
fix: cache vehicle cargo recharge targets#8521scarf005 wants to merge 2 commits intocataclysmbn:mainfrom
scarf005 wants to merge 2 commits intocataclysmbn:mainfrom
Conversation
Assisted-by: openai/gpt-5.4 on opencode Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Assisted-by: openai/gpt-5.4 on opencode Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Vehicle recharge processing was rescanning cargo contents every turn in item-heavy vehicles, and solar-equipped battery buses were also paying repeated battery-part scans in vehicle power paths. Together they made crafting, reading, and nearby vehicle turns stutter again around large mobile bases.
Likely BN regression sources:
#8252feat!: Map Data Overhaul; dynamic reality bubble, chunk loader, multi-dimension, and more#8439fix: activity bubble resize works w/ craftingDescribe the solution (The How)
Testing
cmake --build --preset linux-full --target cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "[vehicle][power]"./out/build/linux-full/tests/cata_test-tiles "[grids][vehicle]"./out/build/linux-full/tests/cata_test-tiles "[benchmark][vehicle]" --benchmark-samples 1 --benchmark-resamples 0process_items with recharge station and 8196 cargo items412.318 us6.401 us64.4xvehicle idle with 64 solar panels and 512 storage batteries166.974 us115.568 us1.44xvehicle solar backfill with 64 panels and 512 storage batteries157.827 us124.385 us1.27xAdditional context
Reproduction reports:
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.PR opened by gpt-5.4 high on opencode