Skip to content

feat: allow reloading multiple solids#8369

Open
shmakota wants to merge 4 commits intocataclysmbn:mainfrom
shmakota:reloading_multiple_solids
Open

feat: allow reloading multiple solids#8369
shmakota wants to merge 4 commits intocataclysmbn:mainfrom
shmakota:reloading_multiple_solids

Conversation

@shmakota
Copy link
Copy Markdown
Collaborator

Purpose of change (The Why)

We now have the ability to reload containers, but only one at a time. However the engine supports multiple items in one container.

Describe the solution (The How)

Allow reloading multiple items into one container.

Also adds the ability to select a specific item to unload from a container with multiple items.

Describe alternatives you've considered

Testing

Spawned a cardboard box and a variety of items, reloaded it.

Additional context

Checklist

Mandatory

Optional

  • This PR ports commits from DDA or other cataclysm forks.
    • I have added port scope to the PR title.
    • I have attributed original authors in the commit messages adding Co-Authored-By in the commit message.
    • I have linked the URL of original PR(s) in the description.
  • This is a C++ PR that modifies JSON loading or behavior.
    • I have documented the changes in the appropriate location in the docs/ folder.
    • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
    • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
    • If applicable, add checks on game load that would validate the loaded data.
    • If it modifies format of save files, please add migration from the old format.
  • This is a PR that modifies build process or code organization.
    • Please document the changes in the appropriate location in the docs/ folder.
    • If documentation for this feature or process does not exist, please write it.
    • If the change alters versions of software required to build or work with the game, please document it.
  • This is a PR that removes JSON entities.
    • The removed JSON entities have new entries in data/json/obsoletion/ folder or use some other migration process for existing saves.
  • This PR adds/removes a mod.
    • I have added mods scope to the PR title.
    • The mod_name in data/mods/<mod_name> matches id in modinfo.json.
    • I have committed the output of deno task semantic.
  • This PR modifies lua scripts or the lua API.

@github-actions github-actions bot added the src changes related to source code. label Mar 24, 2026
@autofix-ci
Copy link
Copy Markdown
Contributor

autofix-ci bot commented Mar 24, 2026

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

Copy link
Copy Markdown
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedloaders keep having a test failure it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

src changes related to source code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants