feat: allow reloading multiple solids#8369
Open
shmakota wants to merge 4 commits intocataclysmbn:mainfrom
Open
feat: allow reloading multiple solids#8369shmakota wants to merge 4 commits intocataclysmbn:mainfrom
shmakota wants to merge 4 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
chaosvolt
requested changes
Apr 4, 2026
Member
chaosvolt
left a comment
There was a problem hiding this comment.
Speedloaders keep having a test failure it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
We now have the ability to reload containers, but only one at a time. However the engine supports multiple items in one container.
Describe the solution (The How)
Allow reloading multiple items into one container.
Also adds the ability to select a specific item to unload from a container with multiple items.
Describe alternatives you've considered
Testing
Spawned a cardboard box and a variety of items, reloaded it.
Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
portscope to the PR title.Co-Authored-Byin the commit message.docs/folder.lang/bn_extract_json_strings.shscript if it does not support them yet.docs/folder.data/json/obsoletion/folder or use some other migration process for existing saves.modsscope to the PR title.mod_nameindata/mods/<mod_name>matchesidinmodinfo.json.deno task semantic.luascope to the PR title.