Skip to content

Update quad chart with mermaid - #1942

Open
brownsarahm wants to merge 2 commits into
mainfrom
mermaid-quad
Open

Update quad chart with mermaid#1942
brownsarahm wants to merge 2 commits into
mainfrom
mermaid-quad

Conversation

@brownsarahm

Copy link
Copy Markdown
Member

I have not tested this with varnish yet and there may be an issue with the alt text so that needs to be addressed, but this is a start!

closes #1801

@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1942

The following changes were observed in the rendered markdown documents:

 08-motivation.md | 51 +++++++++++++++++++++++++++++++++++++++++++++++++--
 md5sum.txt       |  2 +-
 2 files changed, 50 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-06-04 00:32:54 +0000

github-actions Bot pushed a commit that referenced this pull request Dec 3, 2025
@ndporter

Copy link
Copy Markdown
Contributor

I built this locally to check the charts and some of the text on the parking one is off the chart, literally. See image.

Screenshot 2025-12-17 at 15 39 11

@ndporter

Copy link
Copy Markdown
Contributor

There are also some caption and/or alt-text issues to fix, and I'm submitting something to workbench to fix contrast on source code. But once the diagram is fixed, we can work on those.

@brownsarahm
brownsarahm marked this pull request as ready for review June 4, 2026 00:31
github-actions Bot pushed a commit that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove contraction from image

2 participants