Ensure rounding errors don't make unquantized values too big#4777
Open
AnyOldName3 wants to merge 1 commit intobulletphysics:masterfrom
Open
Ensure rounding errors don't make unquantized values too big#4777AnyOldName3 wants to merge 1 commit intobulletphysics:masterfrom
AnyOldName3 wants to merge 1 commit intobulletphysics:masterfrom
Conversation
Potential fix for bulletphysics#4768 Floating point maths doesn't guarantee that quantizing and dequantizing a value will give the same value, even when it started as the extreme of the quantization range and therefore doesn't lose any precision from the quantization itself. Example values that demonstrate this are given in the linked issue. This doesn't appear to be quite the same problem as DEBUG_CHECK_DEQUANTIZATION checks for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #4768
Floating point maths doesn't guarantee that quantizing and dequantizing a value will give the same value, even when it started as the extreme of the quantization range and therefore doesn't lose any precision from the quantization itself. Despite that, there are assertions in Bullet that fail when it doesn't happen.
Example values that demonstrate this are given in the linked issue.
This doesn't appear to be quite the same problem as
DEBUG_CHECK_DEQUANTIZATIONchecks for.