Fix GImpact algo registration issue#4721
Open
kvasnevskyivlad wants to merge 1 commit intobulletphysics:masterfrom
Open
Fix GImpact algo registration issue#4721kvasnevskyivlad wants to merge 1 commit intobulletphysics:masterfrom
kvasnevskyivlad wants to merge 1 commit intobulletphysics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After I updated the version of Bullet to the latest one, I noticed that GImpact collision functionality, namely
contactPairTestdoesn't work anymore. So after some time, I found out this discussion - #3747 with a reference to this commit 9ee1c4e. I noticed that with that commit were introduced two "kinds" of algos:and by default, we use
BT_CLOSEST_POINT_ALGORITHMS. But in theregisterAlgorithmmethod inbtGImpactCollisionAlgorithm.cpp, the GImpact algorithm is registered only asBT_CONTACT_POINT_ALGORITHMS, so if you callcontactPairTest, it doesn't work.I am not sure whether my fix is correct, but it works for me, so to fix it, I added registration for
BT_CLOSEST_POINT_ALGORITHMSas well.