unity-setup@v1.2.5#32
Merged
Merged
Conversation
- fix partial version matching (again)
There was a problem hiding this comment.
Pull Request Overview
This PR addresses partial version matching issues in the unity-setup action and bumps the version to v1.2.5. The primary goal is to fix the sorting order for fallback version matching to prioritize higher versions over lower ones.
Key changes:
- Fixed version fallback logic to sort in descending order (highest first) instead of ascending
- Added validation logic in the build workflow to verify Unity version compatibility
- Updated package dependencies to newer versions
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/unity-version.ts | Fixed sorting order for version fallback and improved code formatting |
| package.json | Bumped version to 1.2.5 and updated dependencies |
| .github/workflows/build.yml | Added Unity version validation logic to verify compatibility |
| .github/workflows/build-options.json | Added new Unity version "6000.1" to test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added additional tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
,