unity-setup@v1.2.3#30
Merged
Merged
Conversation
StephenHodgson
commented
Jul 31, 2025
Member
- fix editor path lookup
- fix editor path lookup
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Unity editor path lookup logic by adding an exact version matching preference before falling back to semantic version matching, and bumps the version to 1.2.3.
- Implements exact version matching as the preferred method for finding Unity editors
- Maintains semantic version matching as a fallback for compatibility
- Updates package version to reflect the bug fix
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/unity-hub.ts | Adds exact version matching logic before semantic version fallback |
| package.json | Bumps version from 1.2.2 to 1.2.3 |
Comments suppressed due to low confidence (1)
src/unity-hub.ts:478
- This closing brace doesn't match the control structure. The
elseblock starting at line 457 should close before this brace, but there's an extra closing brace here that breaks the if-else structure.
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.