unity-setup@v1.2.2#29
Merged
Merged
Conversation
StephenHodgson
commented
Jul 30, 2025
Member
- fix version matching
- fix version matching
There was a problem hiding this comment.
Pull Request Overview
This PR fixes version matching in the Unity setup action by implementing exact version matching first before falling back to caret range matching, and corrects a method name typo.
- Improves version matching logic to prioritize exact matches over semver range matching
- Fixes a typo in architecture string handling from
toLocaleLowerCase()totoLowerCase() - Updates package version to v1.2.2
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/unity-version.ts | Implements exact version matching first, then fallback to caret range only for x.0.0 versions |
| src/unity-hub.ts | Moves editor path check earlier and fixes method name typo |
| package.json | Bumps version to 1.2.2 |
Comments suppressed due to low confidence (1)
src/unity-version.ts:53
- [nitpick] The variable names
minorIsZeroandpatchIsZerocould be more descriptive. Consider renaming toisMinorZeroandisPatchZeroto follow boolean naming conventions.
let minorIsZero = false, patchIsZero = false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.