Build backend with docker#527
Open
phlmn wants to merge 9 commits into
Open
Conversation
phlmn
force-pushed
the
web-docker
branch
11 times, most recently
from
d88e2d8 to
0a0208a
Compare
phlmn
force-pushed
the
web-docker
branch
2 times, most recently
from
6cff2d5 to
458a0ea
Compare
anuejn
reviewed
May 16, 2026
Member
anuejn
left a comment
anuejn
left a comment
There was a problem hiding this comment.
could you also delete the nix folder?
anuejn
approved these changes
May 16, 2026
phlmn
force-pushed
the
web-docker
branch
4 times, most recently
from
6e70690 to
1afa048
Compare
anuejn
requested changes
May 17, 2026
Member
There was a problem hiding this comment.
I would like to not have this as a toplevel file. I would be okay to leave the versions separate (we already have to change it in multiple places anyway) and this suggests, that this is the only place to change it (it is not).
Member
There was a problem hiding this comment.
I actually like the dev.sh being in packaging
Member
There was a problem hiding this comment.
could you move this to packaging/ and document this somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.