chore: preview spec migration to mix_generator on btwld/mix#918#54
Draft
tilucasoli wants to merge 1 commit into
Draft
chore: preview spec migration to mix_generator on btwld/mix#918#54tilucasoli wants to merge 1 commit into
tilucasoli wants to merge 1 commit into
Conversation
Migrates 23 spec classes from `extends Spec<FooSpec> with Diagnosticable, _$FooSpecMethods` to `with _$FooSpec`, the new self-contained mixin pattern emitted by mix_generator on btwld/mix#918. Regenerates all `*.g.dart` files against that branch so the team can preview the diff. Depends on btwld/mix#918 — do not merge until that PR is published. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preview-only PR to show the team what remix looks like after migrating to the new mix_generator emitted by btwld/mix#918.
*_spec.dartclasses dropextends Spec<FooSpec> with Diagnosticable, _$FooSpecMethodsin favor of the new self-containedwith _\$FooSpecmixin.*.g.dartfiles are regenerated against PR #918'schore/code-generation-clean-upbranch — the new mixin owns==,hashCode,props,toString,toDiagnosticsNode,debugFillProperties,getDiff, etc. directly instead of inheriting fromSpec.Local verification:
dart run build_runner buildsucceeds,flutter analyzereports no issues, and all 1722 tests pass whenmix/mix_annotations/mix_generatorare overridden to PR #918.Related Issues
Depends on btwld/mix#918 — do not merge until that PR is published.
packages/remix/build.yamlstill references the now-removedmix_generator:spec/mix_generator:propertybuilder ids and will need cleanup as a follow-up.Checklist
Breaking Change
🤖 Generated with Claude Code