Skip to content

Add Hue / Signify Garnea Downlight and Calla Large Outdoor Pedestal profiles#3185

Merged
bramstroker merged 6 commits intobramstroker:masterfrom
stormshaker:master
Mar 21, 2025
Merged

Add Hue / Signify Garnea Downlight and Calla Large Outdoor Pedestal profiles#3185
bramstroker merged 6 commits intobramstroker:masterfrom
stormshaker:master

Conversation

@stormshaker
Copy link
Copy Markdown
Contributor

When create a PR for new measurements to the library, please go the the Preview tab and select the power-profile template:
If you are issuing a new PR for other purpose you can remove all this text.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2025

Thank you for submitting light measurements!
Here are some visualizations for the CSV files.

Image
Image

Copy link
Copy Markdown
Owner

@bramstroker bramstroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. measurements look great. One small remark.

Comment thread profile_library/signify/LTD011/model.json Outdated
@stormshaker
Copy link
Copy Markdown
Contributor Author

Great - updated model.json to remove typo :)

@stormshaker stormshaker changed the title Add Phillips Hue / Signify Garnea Downlight profile Add Hue / Signify Garnea Downlight and Calla Large Outdoor Pedestal profiles Mar 13, 2025
@stormshaker
Copy link
Copy Markdown
Contributor Author

Sorry, pushed my second profile to my forked master branch and I think it's been included in this PR. So, two profiles one PR. I'm pretty new to this. Hope that's OK :)

@bramstroker
Copy link
Copy Markdown
Owner

Sorry, pushed my second profile to my forked master branch and I think it's been included in this PR. So, two profiles one PR. I'm pretty new to this. Hope that's OK :)

No problem. Next time you can create a new branch (look it up in google), you can commit and make new PR from that branch. That will allow to work simultanaously on multiple at the same time.
When you need to make change add commit to related branch and it will update the PR.

@bramstroker
Copy link
Copy Markdown
Owner

There are some outliers to be seen in the Graph which look incorrect to me.
Are you able to redo hs until the 66 brightness level to see if it's reproducable?

68747470733a2f2f692e696d6775722e636f6d2f36426d786133512e706e67

2,21849,65,0.37
2,24580,65,0.33
2,27311,65,0.36
2,30042,65,0.37
2,32773,65,0.36
2,35504,65,2.34     INCORRECT
2,38235,65,0.37
2,40966,65,0.39
2,43697,65,4.6      INCORRECT
2,46428,65,0.34
2,49159,65,0.36
2,51890,65,0.36

@stormshaker
Copy link
Copy Markdown
Contributor Author

I reran the full hs profile for the signify/1743730P7 today, and results look cleaner. Could you re-run the visualisation and check?

@stormshaker
Copy link
Copy Markdown
Contributor Author

@bramstroker Do you need anything else from me? I've made the name change as requested, and have uploaded the new hs data for the pedestal lights.

@bramstroker
Copy link
Copy Markdown
Owner

Yes looking good now. Thanks a lot!

hs

@bramstroker bramstroker merged commit 1ff566d into bramstroker:master Mar 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants