Skip to content

Card fields analytics#1618

Merged
buzzamus merged 1 commit into
card-fields-featurefrom
cardFields-analytics
Jun 16, 2026
Merged

Card fields analytics#1618
buzzamus merged 1 commit into
card-fields-featurefrom
cardFields-analytics

Conversation

@buzzamus

Copy link
Copy Markdown
Contributor

Summary of changes

Note: This PR depends on PR #1617 so, it currently has the commits from that PR in this one, but once that branch is merged into the feature branch I will rebase off of that branch. To review the code for just this PR look at my commit (65120ba)

  • Adds 2 events for CardFields: presented for when the view renders and validated for when the form is validated and the submit button is selected
  • Verified events trigger and that the session ID is shared among events

AI Usage

Which AI Agent Was Used?

  • Copilot
  • Claude
  • Other (Type Name Here)

How was AI used?
Claude wrote unit tests for me and also helped with syntax of getting into Android Views.

Estimated AI Code Contribution

  • less than 30%
  • 30 - 60%
  • 60 - 100%

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@buzzamus buzzamus requested a review from a team June 12, 2026 20:09
@buzzamus buzzamus requested a review from a team as a code owner June 12, 2026 20:09
@noguier

noguier commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Did you verify that new events are present in the lighthouse, by chance?

@buzzamus

Copy link
Copy Markdown
Contributor Author

Did you verify that new events are present in the lighthouse, by chance?

Yep, I verified the events are received as well as them sharing the same session ID as all other events from the same session.

@noguier

noguier commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Hey, the end-to-end card payment flow PR was merged, would you mind rebasing this PR 🙏

@buzzamus buzzamus force-pushed the cardFields-analytics branch from 65120ba to 7bdb8e4 Compare June 15, 2026 13:30
@buzzamus

Copy link
Copy Markdown
Contributor Author

Rebased off of feature to clean up git history

@noguier noguier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. Just to clarify we are sending VALIDATED event, when all of the fields are validated and right before we initiate the card flow, correct?

@buzzamus

Copy link
Copy Markdown
Contributor Author

This looks great, thank you. Just to clarify we are sending VALIDATED event, when all of the fields are validated and right before we initiate the card flow, correct?

Correct: The event fires when all fields are valid and the submit action has been triggered, so the next event we see after VALIDATED should be the tokenize request

@saralvasquez saralvasquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉 Just triple checking we have consistent analytics naming across iOS and Android right? I recall you asking about that but never followed up

@buzzamus

Copy link
Copy Markdown
Contributor Author

Looks good to me! 🎉 Just triple checking we have consistent analytics naming across iOS and Android right? I recall you asking about that but never followed up

Yep! Analytics names are matching across both platforms

@buzzamus buzzamus merged commit db71f1d into card-fields-feature Jun 16, 2026
13 of 14 checks passed
@buzzamus buzzamus deleted the cardFields-analytics branch June 16, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants