Card fields analytics#1618
Conversation
|
Did you verify that new events are present in the lighthouse, by chance? |
Yep, I verified the events are received as well as them sharing the same session ID as all other events from the same session. |
|
Hey, the end-to-end card payment flow PR was merged, would you mind rebasing this PR 🙏 |
65120ba to
7bdb8e4
Compare
|
Rebased off of feature to clean up git history |
noguier
left a comment
There was a problem hiding this comment.
This looks great, thank you. Just to clarify we are sending VALIDATED event, when all of the fields are validated and right before we initiate the card flow, correct?
Correct: The event fires when all fields are valid and the submit action has been triggered, so the next event we see after VALIDATED should be the tokenize request |
saralvasquez
left a comment
There was a problem hiding this comment.
Looks good to me! 🎉 Just triple checking we have consistent analytics naming across iOS and Android right? I recall you asking about that but never followed up
Yep! Analytics names are matching across both platforms |
Summary of changes
Note: This PR depends on PR #1617 so, it currently has the commits from that PR in this one, but once that branch is merged into the feature branch I will rebase off of that branch. To review the code for just this PR look at my commit (65120ba)
presentedfor when the view renders andvalidatedfor when the form is validated and the submit button is selectedAI Usage
Which AI Agent Was Used?
How was AI used?
Claude wrote unit tests for me and also helped with syntax of getting into Android Views.
Estimated AI Code Contribution
Checklist
Authors