fix: remove deprecated GooglePay functionality in favour of TaskResultContracts by saralvasquez · Pull Request #1616 · braintree/braintree_android

saralvasquez · 2026-06-11T17:41:37Z

Summary of changes

This ticket came in as a part of a github issue. The problem was that we were still using a depreacted method that was later removed in newer versions of google wallet in the google pay component. The newer recommended method of gathering payment data from google pay allows for pretty big changes to the SDK. This includes getting rid of GooglePayActivity and GooglePayActivityResultContract since the result handling is covered by the new TaskResultContracts. More detailed summary below with documentation from google used to put this PR together

Replaces the internal GooglePayActivity and AutoResolveHelper pattern with TaskResultContracts.GetPaymentDataResult() API from Google Wallet
Merchants no longer need to declare GooglePayActivity in their AndroidManifest.xml — the SDK handles the payment sheet launch entirely through the activity result contract mechanism
Moves loadPaymentData() into GooglePayInternalClient so GooglePayLauncher drives the task directly, and result parsing is now handled inline in the launcher callback

Google documentation:
https://developers.google.com/android/reference/com/google/android/gms/wallet/contract/TaskResultContracts
https://developers.google.com/pay/api/android/guides/tutorial#initiate-payment
Sample integration pattern:
https://github.com/google-pay/android-quickstart/blob/468fc42e6d465e1b296bf2441835c3f053ef2c4b/java/app/src/main/java/com/google/android/gms/samples/pay/activity/CheckoutActivity.java

Note on deleted files - these changes feel like they are on the border of a major version change but all the changes are to internal files only so integrations shouldn't need to change. Let me know what you all think

AI Usage

Which AI Agent Was Used?

Copilot
Claude
Other (Type Name Here)

How was AI used?
Used claude code to research sources for replacements for the deprecated method and for suggestions on how to integrate the new preferred methods into our code base. Let it generate tests to cover the changed functionality

Estimated AI Code Contribution

less than 30%
30 - 60%
60 - 100%

Checklist

Added a changelog entry
Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@saralvasquez

… pay

github-actions · 2026-06-11T17:42:24Z

Dependency Review

✅ No vulnerabilities found.

Scanned Files

None

jaxdesmarais

I mainly just have general questions around my own understanding of Android and the new API. Overall it looks like this change cleans up a lot of old code which is a win in my book. It also looks to be non breaking, so seems like a good change to make.

jaxdesmarais · 2026-06-15T15:11:20Z

-    private val activityLauncher: ActivityResultLauncher<GooglePayPaymentAuthRequestParams> = registry.register(
+    private val appContext: Context = context.applicationContext
+
+    private val activityLauncher: ActivityResultLauncher<Task<PaymentData>> = registry.register(


It seems like this is the crux of the change. Are the any implications to older APIs or is this fully backwards compatible?

Great question. I tested with older versions of the APIs on emulator and it worked just fine but I'll make sure to test on all supported API versions to make sure we won't run into issues

Ok so I couldn't get some of the older emulators to work well enough to test, but we do have confirmation that the new API is backwards compatible back to versions that are so old we don't even support. So I think we should be good

noguier · 2026-06-15T21:33:52Z

+                GooglePayPaymentAuthResult(
+                    null,
+                    GooglePayException(
+                        "An error was encountered during the Google Pay " +


is there a way we can display the status object in our demo app, so that we can see what caused an error right away?

This is actually already covered in the demo app. This PR doesn't change how results are getting delivered, it only changes what's delivering them. If you take a look at the delete results contract file you can see that the handling of the payment status and sending of GooglePayPaymentAuthResult are very similar to how it looks in the Launcher now

Thank you very much, I can see it now!

noguier

While i am still going through all the code changes, I just wanted to confirm that i tested the flow on the physical device, and API 23, and all are working as expected.

noguier · 2026-06-15T22:16:16Z

I see the EXTRA_ENVIRONMENT and EXTRA_PAYMENT_DATA_REQUEST constants are being deprecated rather than deleted, but GooglePayActivity is being deleted. In what situations do we usually deprecate first and then remove, vs remove right away like the GooglePayActivity? Since we are changing the manifest, will it affect merchants with old API?

saralvasquez · 2026-06-15T23:21:56Z

Great question! The general rule is that if the merchant can touch a piece of code you can't delete it until a major version. Those constants are technically publicly accessible by merchants. They shouldn't/wouldn't ever have used them for anything, but since they could be accessed it's safer to deprecate than completely remove them. The files that were deleted on the other hand were all internal so there is no chance that a merchant would be using any piece of them and are safe to completely delete. After some searching it looks like the changes that Google made to wallet that allowed this PR are backwards compatible all the way to version 21 which we don't even support so we should be fine for all API version we support in the SDK

noguier · 2026-06-16T14:48:17Z

This looks good, just a couple of clarifying questions, to get my understanding:
Prior to this changes, we had to create a new activity, that was launching Google Pay, and then handles the result back with onActivityResult. Now we do not have to do it because ActivityResultContract solves the problem of creating an "invisible" just to handle results because we can use TaskResultContracts to launch and deliver results?

noguier · 2026-06-16T14:49:21Z

Also from what I have read, and tested this changes are great and are backwards compatible!

saralvasquez · 2026-06-16T17:10:16Z

This looks good, just a couple of clarifying questions, to get my understanding: Prior to this changes, we had to create a new activity, that was launching Google Pay, and then handles the result back with onActivityResult. Now we do not have to do it because ActivityResultContract solves the problem of creating an "invisible" just to handle results because we can use TaskResultContracts to launch and deliver results?

Yeah exactly! They basically took on the responsibility of launching and delivering results so we don't need to do all the weird handling with the transparent activity or custom results contracts etc. I think you've got a firm understanding of the changes

jaxdesmarais

Thanks for addressing all of my questions/comments. These changes look great and way less code for us to maintain long term. 🚀

saralvasquez added 2 commits June 9, 2026 17:13

fix: change functionality to remove deprecated method calls in google…

915403e

… pay

fix: resolve possible memory leak, add changelog, and new tests

755a9bb

saralvasquez requested a review from a team June 11, 2026 17:41

saralvasquez requested a review from a team as a code owner June 11, 2026 17:41

jaxdesmarais reviewed Jun 15, 2026

View reviewed changes

noguier reviewed Jun 15, 2026

View reviewed changes

fix: address PR comments

f75360d

noguier approved these changes Jun 16, 2026

View reviewed changes

jaxdesmarais approved these changes Jun 16, 2026

View reviewed changes

saralvasquez merged commit 8318ad9 into main Jun 16, 2026
12 checks passed

saralvasquez deleted the google-pay-issue branch June 16, 2026 18:33

Conversation

saralvasquez commented Jun 11, 2026

Summary of changes

AI Usage

Checklist

Authors

Uh oh!

github-actions Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

jaxdesmarais left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaxdesmarais Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

saralvasquez Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

saralvasquez Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

noguier Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

saralvasquez Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

noguier Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

noguier left a comment

Choose a reason for hiding this comment

Uh oh!

noguier commented Jun 15, 2026

Uh oh!

saralvasquez commented Jun 15, 2026

Uh oh!

noguier commented Jun 16, 2026

Uh oh!

noguier commented Jun 16, 2026

Uh oh!

saralvasquez commented Jun 16, 2026

Uh oh!

jaxdesmarais left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 11, 2026 •

edited

Loading