using Google Pay button API in demo app by dmengelt · Pull Request #1606 · braintree/braintree_android

dmengelt · 2026-05-27T16:08:46Z

Summary of changes

Uses Google Pay's Pay Button API in the Demo App
Updates play-services-wallet dependency to 19.5.0

screen-20260527-172756-1779895658031.mp4

AI Usage

Which AI Agent Was Used?

Copilot
Claude
Gemini

How was AI used?

code generation
refactoring, debugging

Estimated AI Code Contribution

less than 30%
30 - 60%
60 - 100%

Checklist

Added a changelog entry
Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.
@dmengelt

noguier

Hello, can you please add a CHANGELOG entry to record new playServicesWallet = "19.5.0" dependency

noguier · 2026-05-28T18:12:34Z

+            contentAlignment = Alignment.Center
+        ) {
+            Column(horizontalAlignment = Alignment.CenterHorizontally) {
+                if (isReadyToPay && allowedPaymentMethods.isNotEmpty()) {


should we give user a feedback in case allowedPaymentMethods are empty here?

noguier · 2026-05-28T18:26:46Z

+                        "USD",
+                        "1.00",
+                        GooglePayTotalPriceStatus.TOTAL_PRICE_STATUS_FINAL,
+                        isPayPalEnabled = false


if I set isPayPalEnabled to true nothing renders in this fragment

Yes. The dynamic Google Pay button doesn't work if there is an "type": "PAYPAL" object in the allowedPaymentMethods array.

Interesting. Do you know why that is?

The dynamic button shows the the card art and last4 digits (if the user had a card on file) and therefore primarily works with "type": "CARD".

dmengelt · 2026-06-02T09:24:48Z

Hello, can you please add a CHANGELOG entry to record new playServicesWallet = "19.5.0" dependency

Done. Sorry about that.

noguier

Thank you for addressing my comments!

dmengelt · 2026-06-08T09:24:24Z

@noguier anything more needed from my side or is this ready to merge? 🙂

noguier · 2026-06-08T22:42:14Z

@dmengelt we are just waiting on one more review from my team, thank you for your patience!

saralvasquez

This button looks super cool! I also appreciate the labor to move over to compose. I just have a couple of comments that could use a look. Thanks!

saralvasquez · 2026-06-08T22:40:00Z

 * BraintreeCore
    * Allow fetching of `Configuration` to query supported integrations and card types (fixes #1302)
+* Google Pay
+  * Update Google Pay dependency (play-services-wallet) to version 19.5.0


Can you please move this under an unreleased header at the top of this file? We also try to keep spacing to 4 space tabs, could you try to match that for this entry as well?

I actually had this under the unreleased header: 5fe2d0f#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR7

Updated again 👍

saralvasquez · 2026-06-08T23:00:42Z

+                        "USD",
+                        "1.00",
+                        GooglePayTotalPriceStatus.TOTAL_PRICE_STATUS_FINAL,
+                        isPayPalEnabled = false


Interesting. Do you know why that is?

saralvasquez · 2026-06-08T23:15:59Z

+                    val request = GooglePayRequest(
+                        "USD",
+                        "1.00",
+                        GooglePayTotalPriceStatus.TOTAL_PRICE_STATUS_FINAL,
+                        isPayPalEnabled = false
+                    )
+                    googlePayClient.createPaymentAuthRequest(request) { authRequest ->
+                        if (authRequest is GooglePayPaymentAuthRequest.ReadyToLaunch) {
+                            val json =
+                                JSONObject(authRequest.requestParams.paymentDataRequest.toJson())
+                            allowedPaymentMethods =
+                                json.getJSONArray("allowedPaymentMethods").toString()
+                        }
+                    }


Correct me if I'm reading this wrong, but this whole series of operations looks like a throw away just to gather the value of allowedPaymentMethods. Can you find a way to gather this information without making unnecessary calls? On top of this being slower, createPaymentAuthRequest triggers analytics that would just be noise

saralvasquez · 2026-06-08T23:18:13Z

 cardinal = { group = "org.jfrog.cardinalcommerce.gradle", name = "cardinalmobilesdk", version.ref = "cardinal" }
 paypal-messages = { module = "com.paypal.messages:paypal-messages", version.ref = "paypalMessages" }
-play-services-wallet = { group = "com.google.android.gms", name = "play-services-wallet", version.ref = "playServices" }
+play-services-wallet = { group = "com.google.android.gms", name = "play-services-wallet", version.ref = "playServicesWallet" }


If this rename isn't strictly necessary could you please leave this as is?

I can revert this but playServices is misleading IMO 🙂 WDYT?

Yeah I agree it's not the most intuitive naming. I generally try to keep unnecessary changes to a minimum since it's critical to keep current integrations functioning as expected but I was too hasty here. Renaming something in this file should be 100% safe since it's only internally accessible. Feel free to leave it

dmengelt · 2026-06-15T10:14:48Z

@saralvasquez let me know if any more changes are needed.

dmengelt · 2026-06-15T19:52:11Z

Fixed the Android Lint errors

Signed-off-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com>

saralvasquez

Looks good! 🎉

dmengelt · 2026-06-16T06:44:25Z

@saralvasquez any clue why the dependency-review fails?

dmengelt requested a review from a team May 27, 2026 16:08

dmengelt requested a review from a team as a code owner May 27, 2026 16:08

noguier reviewed May 28, 2026

View reviewed changes

using Google Pay button API in demo app

5fe2d0f

dmengelt force-pushed the demo-app-google-pay-button branch from c6f6829 to 5fe2d0f Compare June 2, 2026 09:23

dmengelt requested a review from noguier June 2, 2026 09:25

noguier approved these changes Jun 4, 2026

View reviewed changes

saralvasquez reviewed Jun 8, 2026

View reviewed changes

dmengelt force-pushed the demo-app-google-pay-button branch from 992fe17 to e1642cb Compare June 15, 2026 10:12

Merge branch 'main' into demo-app-google-pay-button

68d3ded

dmengelt force-pushed the demo-app-google-pay-button branch from e1642cb to 68d3ded Compare June 15, 2026 19:51

saralvasquez reviewed Jun 15, 2026

View reviewed changes

Comment thread CHANGELOG.md

Apply suggestion from @saralvasquez

2454145

Signed-off-by: Sara Vasquez <98496950+saralvasquez@users.noreply.github.com>

saralvasquez approved these changes Jun 15, 2026

View reviewed changes

Conversation

dmengelt commented May 27, 2026

Summary of changes

AI Usage

Checklist

Authors

Uh oh!

noguier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmengelt Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmengelt commented Jun 2, 2026

Uh oh!

noguier left a comment

Choose a reason for hiding this comment

Uh oh!

dmengelt commented Jun 8, 2026

Uh oh!

noguier commented Jun 8, 2026

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmengelt commented Jun 15, 2026

Uh oh!

dmengelt commented Jun 15, 2026

Uh oh!

Uh oh!

saralvasquez left a comment

Choose a reason for hiding this comment

Uh oh!

dmengelt commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dmengelt Jun 15, 2026 •

edited

Loading