Open
Conversation
- Created abstract NfcInterface base class - Refactored NfcHandler to NfcpyHandler implementing NfcInterface - Added create_nfc_handler factory function to select implementations - Added --nfc-implementation command-line option to nfc2klipper_backend.py - Updated MockNfcHandler to implement NfcInterface - Default implementation is 'nfcpy' (current behavior) - Placeholder for 'pn5180-tagomatic' implementation ready for future addition Co-authored-by: bofh69 <1444315+bofh69@users.noreply.github.com>
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. License Issuesrequirements.txt
OpenSSF Scorecard
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Owner
Author
|
@copilot Fix the mypy errors. |
Contributor
bofh69
force-pushed
the
support-openprinttag
branch
from
3530688 to
651fd7a
Compare
Owner
Author
|
@copilot Fix build errors |
Contributor
5 tasks
bofh69
force-pushed
the
support-openprinttag
branch
from
ae85347 to
e5ddcba
Compare
Owner
Author
|
@copilot fix the mypy and pylint errors, without changing the files under open_print_tag |
Contributor
bofh69
force-pushed
the
support-openprinttag
branch
3 times, most recently
from
eb0cc50 to
4d24068
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for OpenPrintTag NFC tags by integrating the OpenPrintTag data format parser and adding PN5180 reader support. The main changes enable nfc2klipper to read OpenPrintTag tags (which use NFC Type-V), parse their structured data, and automatically create corresponding entries in Spoolman.
Changes:
- Added OpenPrintTag parser implementation with field mapping support
- Integrated PN5180 reader support for NFC Type-V tags
- Introduced NFC handler abstraction layer with interface-based design
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| open_print_tag/utils/* | OpenPrintTag reference implementation copied from upstream project |
| lib/openprinttag_parser.py | New parser for OpenPrintTag format with Spoolman integration |
| lib/nfc_handler.py | Refactored to support multiple reader implementations (nfcpy, PN5180) |
| lib/nfc_interface.py | New abstract interface for NFC handlers |
| lib/config.py | Added configuration methods for OpenPrintTag field mappings |
| nfc2klipper_backend.py | Integrated OpenPrintTag parser and PN5180 support |
| nfc2klipper.cfg | Added configuration sections for PN5180 and OpenPrintTag |
| README.md | Updated documentation for PN5180 reader and OpenPrintTag support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bofh69
force-pushed
the
support-openprinttag
branch
from
5f23435 to
d15d74e
Compare
bofh69
changed the title
bofh69
force-pushed
the
support-openprinttag
branch
3 times, most recently
from
ea3b48f to
e8a0b1c
Compare
The intro is updated. Removed the secion about write_tags.py. Minor clarifications.
bofh69
force-pushed
the
support-openprinttag
branch
from
e8a0b1c to
d5f0a53
Compare
Owner
Author
|
@copilot please review, except files under open_print_tag |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenPrintTag support seems to work fine as well as OpenTag3D and reading nfc2klipper's own formatted tags.
There is no support for updating the auxiliary section with the usage yet. Unless using the spool back and forth between a printer with klipper and a Prusa with NFC reader, that's not a drawback.