docs: document populating NOT NULL columns from bulk procedures - #833
Merged
Conversation
Add guidance under 'Adding a column to a table' on keeping a NOT NULL column backwards compatible during rolling deployments when it is populated through an OPENJSON/TVP bulk procedure, using ISNULL at each insert/update site.
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a documentation-only change to No findings. |
Deploying contributing-docs with
|
| Latest commit: |
a6afa23
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d033743a.contributing-docs.pages.dev |
| Branch Preview URL: | https://docs-sql-bulk-not-null-colum.contributing-docs.pages.dev |
theMickster
requested changes
Jul 28, 2026
theMickster
left a comment
theMickster
left a comment
Contributor
There was a problem hiding this comment.
I think we have some improvements to make. Happy to discuss as needed.
theMickster
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds guidance to the SQL code-style doc on keeping a
NOT NULLcolumn backwards compatible during a rolling deployment when it is populated through anOPENJSON/TVP bulk procedure.NOT NULLcolumn from a bulk (JSON/TVP) procedure, nested as an#####sub-section under Adding a column to a table since it continues that section's NOT NULL / backwards-compatibility discussion.NULLand fails theNOT NULLconstraint.ISNULL([Column], {default})pattern.