Skip to content

feat: don't preserve extra container repository path from origin#341

Merged
tompizmor merged 2 commits intov2from
chore/preserve-image-repo
Apr 13, 2026
Merged

feat: don't preserve extra container repository path from origin#341
tompizmor merged 2 commits intov2from
chore/preserve-image-repo

Conversation

@tompizmor
Copy link
Copy Markdown
Member

Summary

This PR upgrades the distribution-tooling-for-helm library to version 0.7.0 and implements changes to better handle container repository structure and URL resolution.

Changes

Dependency Updates

  • Upgraded distribution-tooling-for-helm from v0.6.1 to v0.7.0 to leverage latest features and fixes

Container URL Resolution Enhancement

  • Modified container URL logic: When no explicit containers URL is specified, the system now appends /containers to the charts URL instead of using the same path
  • This prevents collisions between charts and containers when they would otherwise be stored at the same location
  • Example: If charts URL is http://127.0.0.1:5000/library-replicated/charts/photon-5, containers will now use http://127.0.0.1:5000/library-replicated/charts/photon-5/containers

Image Repository Handling

  • Added WithPreserveRepository(false) option to both chart and container unwrapping operations
  • This ensures consistent behavior in how image repositories are handled during the unwrapping process

Testing

  • Added comprehensive unit tests (common_test.go) covering:
    • Container URL resolution when no explicit containers URL is provided
    • Container URL resolution when explicit containers URL is specified
    • Proper URL formatting and scheme handling

Test Plan

  • Unit tests pass for container URL resolution logic
  • Charts and containers are properly separated when using default URL resolution
  • Image repository preservation behavior is consistent across chart and container operations

Signed-off-by: Tomas Pizarro Moreno <tomas.pizarro@broadcom.com>
@tompizmor tompizmor force-pushed the chore/preserve-image-repo branch from 6c3d394 to bfd38ed Compare April 13, 2026 14:13
Signed-off-by: Tomas Pizarro Moreno <tomas.pizarro@broadcom.com>
@tompizmor tompizmor merged commit 8b729db into v2 Apr 13, 2026
9 checks passed
@tompizmor tompizmor deleted the chore/preserve-image-repo branch April 13, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants