Skip to content

BIP-372: Fix references and links formatting and minor typos#1849

Merged
murchandamus merged 1 commit into
bitcoin:masterfrom
mutestt:fix/fix
May 16, 2025
Merged

BIP-372: Fix references and links formatting and minor typos#1849
murchandamus merged 1 commit into
bitcoin:masterfrom
mutestt:fix/fix

Conversation

@mutestt

@mutestt mutestt commented May 13, 2025

Copy link
Copy Markdown
Contributor

Fixed incorrect preposition in key tweaking explanation:

  • multiplied onmultiplied by

  • Clarified BIP-340 key serialization:

    • appending '02'appending '0x02'
  • Removed unnecessary trailing comma in the list of output types

  • Removed erroneous semicolon after URL

@jonatack jonatack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your proposal. We usually no longer merge "fix typos and grammar" PRs directly, as we were seeing a high frequency of them, they can require more time than they are worth, and they create unneeded notifications for subscribers to this repository. We instead batch these kinds of changes into an occasional cleanup by the editors and credit you as an author when we do that.

That said, I think this pull could add value beyond "typo fixes" if you update it to also convert the non-functional links to mediawiki format. Thoughts?

Comment thread bip-0372.mediawiki Outdated
@mutestt

mutestt commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

@jonatack
I’ve updated the PR as suggested: all non-functional and raw URLs in the references section have now been converted to proper MediaWiki format.
Please let me know if anything else needs to be adjusted.

@jonatack

Copy link
Copy Markdown
Member

Looks good, modulo why did you add italics, and then remove them again in the last commit ce19ffa? (No strong opinion but does seem more readable with italics.)

@jonatack jonatack changed the title BIP-372: Fix typos and grammatical inconsistencies BIP-372: Fix references and links formatting and minor typos May 15, 2025
@mutestt

mutestt commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

@jonatack
I’ve restored the italics around the reference titles as suggested. Let me know if there’s anything else you'd like adjusted.

@jonatack

Copy link
Copy Markdown
Member

ACK bd599fb

@murchandamus murchandamus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed the six commits.

LGTM

@murchandamus murchandamus merged commit 25f6396 into bitcoin:master May 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants