BIP-372: Fix references and links formatting and minor typos#1849
Conversation
jonatack
left a comment
There was a problem hiding this comment.
Thank you for your proposal. We usually no longer merge "fix typos and grammar" PRs directly, as we were seeing a high frequency of them, they can require more time than they are worth, and they create unneeded notifications for subscribers to this repository. We instead batch these kinds of changes into an occasional cleanup by the editors and credit you as an author when we do that.
That said, I think this pull could add value beyond "typo fixes" if you update it to also convert the non-functional links to mediawiki format. Thoughts?
|
@jonatack |
|
Looks good, modulo why did you add italics, and then remove them again in the last commit ce19ffa? (No strong opinion but does seem more readable with italics.) |
|
@jonatack |
|
ACK bd599fb |
murchandamus
left a comment
There was a problem hiding this comment.
Squashed the six commits.
LGTM
Fixed incorrect preposition in key tweaking explanation:
multiplied on→multiplied byClarified BIP-340 key serialization:
appending '02'→appending '0x02'Removed unnecessary trailing comma in the list of output types
Removed erroneous semicolon after URL